Search text only in list#7006
Merged
tomhughes merged 1 commit intoopenstreetmap:masterfrom Apr 19, 2026
Merged
Conversation
pablobm
approved these changes
Apr 17, 2026
Contributor
pablobm
left a comment
pablobm
left a comment
There was a problem hiding this comment.
Uh, that's interesting. The find_by_id("language_search") has the waiting behaviour, but I don't think that send_keys does. Then assert_no_content comes straight from Minitest, so it definitely doesn't wait. Therefore, the find_by_id you are proposing might be all that we were missing! 🤞
Member
|
Well it's worked actions, and we have a theory as to why it might work better, so I say we give it a go. |
Contributor
|
Still failing 😭 https://github.com/openstreetmap/openstreetmap-website/actions/runs/24746462831/job/72399261015?pr=7017 (double checked that it branches from after this merge). |
Collaborator
Author
|
Worth a try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet another try to get the devcontainer workflow to be less flakey