Interface to configure notification preferences

[pablobm]

Closes #6897

This introduces a form under Preferences to configure notification preferences. At the moment this just means checkboxes for things like "I want to receive emails when I get changeset comments, but not when I receive diary comments".

I am storing preferences under user_preferences, in the format :k => "notification.changeset_comment.email"/:v => "t". The table is there and seems like the right place. I could have gone for an array value instead ("notification.changeset_comment"/["email"]), but my choice simplifies serializing/deserializing and is easier to query.

I have changed the labels in the Preferences section as they read "Preferences" a bit too redundantly. Let me know if you can think of better names, particularly for the first one.

[pablobm]

This is currently deployed on the dev server at https://pablobm.apis.dev.openstreetmap.org. There are a couple of users you can use to try out things: mapper and anothermapper, both with password password.

[tomhughes]

From on overall point of view, is it a good idea to let people start turning email notifications off before we have in-site notifications working?

[pablobm]

As I understand it, the logic is that people are already ignoring/filtering their notification emails, so this doesn't make a big difference.

[1ec5]

The only ones that are fairly critical are changeset comments and note comments. We could perhaps disable those checkboxes for now until the in-site option is available. Direct messages already have an in-site indicator of course. New followers might not matter to some users.

[pablobm]

We could perhaps disable those checkboxes for now until the in-site option is available.

That sounds reasonable to me. What do the maintainers think?

[pablobm]

Forgot to mention: this doesn't include preferences for the notifications on GPX import success/failure, as that would require #6939 to be merged first. I think that's ok as they can be added in a later PR.

[gravitystorm]

We could perhaps disable those checkboxes for now until the in-site option is available.

That sounds reasonable to me. What do the maintainers think?

I'm happy to let users control whether they receive notification emails. If we forbid them from turning them off, then they are more likely to get frustrated and/or mark the emails as spam.

I realise that we've managed a decade without being able to turn them off, but now that we have the option it would be unexpected to prohibit using it.

[tomhughes]

As #6939 is now merged should we add the GPX notification to this before we merge it?

[tomhughes]

The last commit should probably add tests for the GPX notifiers that you've now added preferences for?

There also seems to be a failing test?

[pablobm]

Yeah, sorry, I had to go in the middle of it. I'll complete tomorrow.

[github-actions]

	1 Warning
⚠️	Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more?

Generated by 🚫 Danger

[pablobm]

This should be ready now. Gets labelled as "big-pr" particularly because testing each notification type requires ~40 lines of code. Could be DRY'ed up, but I think it would make it more clever than actually maintainable.

[tomhughes]

Thanks for all the work. I think this looks good now.