Disable reverse geocoding in directions test#6963
Merged
tomhughes merged 1 commit intoopenstreetmap:masterfrom Apr 8, 2026
Merged
Disable reverse geocoding in directions test#6963tomhughes merged 1 commit intoopenstreetmap:masterfrom
tomhughes merged 1 commit intoopenstreetmap:masterfrom
Conversation
hlfan
force-pushed
the
no-nomatim-tests
branch
2 times, most recently
from
5f39e85 to
f211c22
Compare
Contributor
|
I'm not aware of this one. Do you have examples of breakage in CI? |
Contributor
|
OK so, if I understand correctly, the Nominatim requests are often not resolved quick enough. As a result the interface may not have updated and we are comparing the wrong things. To solve this you simply disable the Nominatim requests. Why the |
Member
|
Is it hitting the live nominatim then? Surely it should be stubbed in test? |
Collaborator
Author
Contributor
So there ARE issues 😄 Care to share your problems at #6713, please? 🙂 |
pablobm
reviewed
Apr 7, 2026
pablobm
reviewed
Apr 7, 2026
pablobm
approved these changes
Apr 8, 2026
Member
|
Looks good to me, and I'm fed up with randomly hitting that failure, so thanks. I wonder if we should be thinking about a general stub to block external accesses in system tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These unnecessary test failures have been bugging me. The solution doesn't need to be that oversimplified tho.