Refactor hash methods to accept callbacks#12188
Merged
Merged
Conversation
tyrasd
reviewed
Apr 10, 2026
hlfan
commented
Apr 13, 2026
hlfan
force-pushed
the
hash-update
branch
2 times, most recently
from
a3d3f91 to
4736787
Compare
Contributor
Author
|
I've moved |
Member
|
@hlfan it seems like you're continuing to find to improvements for this functionality. 👍 let me know once you're happy for this to be reviewed/merged. |
Contributor
Author
|
I'm happy about a review anytime @tyrasd! I think it is now where I wanted to get it to in terms of modularity after noticing the singleton behaviour bug. |
tyrasd
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window.history.replaceStateis called in many places with an identical need for object <-> querystring conversion.A new exposed
updatemethod can remove quite a bit of duplicate code.Collecting these actions also increases modularity for things like dispatching events (openstreetmap/openstreetmap-website#6811).