Add postgis to all dev rails databases#839
Merged
Merged
Conversation
This is in anticipation of the upcoming "moderation zones" feature. openstreetmap/openstreetmap-website#6713
ceac010 to
9a473cd
Compare
Member
|
Looks good to me, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in anticipation of the upcoming "moderation zones" feature.
openstreetmap/openstreetmap-website#6713
I've tested this using the following config in test-kitchen.yml:
dev: rails: postgresql_cluster: 17/main + sites: + master: + repository: "https://github.com/pablobm/openstreetmap-website.git" + revision: "geoblock-notes" - name: devicesIt confirms that we can create the extension using a superuser (e.g. the
postgresuser) and the migrations work fine when run as a non-superuser, since the migration usesCREATE EXTENSION IF NOT EXISTSI thought it was best to create this PR just for the
devcookbook, and then I'm happy to make a separate follow-on PR for doing the same for the main production db. I expect we'll want to test this on dev and iron out any kinks first.Note that the
devrecipe currently fails in CI (and in test-kitchen), since it picks up the new "dummy" user from the databags and then tries to accessnode[:accounts][:users]but this attribute does not exist for the dev cookbook currently. I worked around that by commenting out that section of the recipe. I'm happy to wait for that to be fixed and then rebase this PR, if that makes life any easier.