Skip to content

adds test to search through all unzipped docx files#2916

Open
omehes wants to merge 83 commits into
mainfrom
docxsearch
Open

adds test to search through all unzipped docx files#2916
omehes wants to merge 83 commits into
mainfrom
docxsearch

Conversation

@omehes
Copy link
Copy Markdown
Contributor

@omehes omehes commented Apr 9, 2026

@omehes omehes requested a review from a team as a code owner April 9, 2026 20:06
@omehes omehes requested a review from TomWoodward April 9, 2026 20:06
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 9, 2026 20:06 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 10, 2026 10:44 Inactive
Copy link
Copy Markdown
Member

@TomWoodward TomWoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm interpreting that this test is unzipping files in you local downloads folder and asserting that they have docx files in them, and i'm assuming that there are probably other tests that run before this that trigger the download?

i'm not sure this test is really providing value, i would focus on testing things that are related to the logic/function of the CMS, not the content itself. these zip files are uploaded by the content management team. if the zip files were somehow dynamically generated it'd be worth it, but since they're manually added this seems like a very odd testing pattern for something that is really out of the scope of the app.

@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 13, 2026 13:29 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 13, 2026 13:37 Inactive
@omehes
Copy link
Copy Markdown
Contributor Author

omehes commented Apr 13, 2026

@TomWoodward This is not a test file but rather a tool for me to be able to search through docx files for a string or anything in the content of the book.

@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 13, 2026 15:00 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 13, 2026 15:09 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 13, 2026 15:18 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 13, 2026 15:41 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 13, 2026 18:40 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 14, 2026 15:47 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 14, 2026 19:26 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 14, 2026 20:55 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 14, 2026 21:15 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 28, 2026 15:27 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 28, 2026 21:43 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 29, 2026 15:41 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u April 29, 2026 18:22 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u May 4, 2026 18:13 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u May 4, 2026 18:32 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u May 5, 2026 21:39 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u May 6, 2026 22:53 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u May 8, 2026 15:04 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u May 11, 2026 21:58 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u May 13, 2026 15:51 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u May 14, 2026 15:37 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u May 14, 2026 15:51 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-docxsearch-kbsblgjml8u May 15, 2026 13:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants