Skip to content

Add 4.22-ha-vs-two-node-arbiter view.#3422

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
jogeo:Add_TNA_compare_view
Apr 10, 2026
Merged

Add 4.22-ha-vs-two-node-arbiter view.#3422
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
jogeo:Add_TNA_compare_view

Conversation

@jogeo
Copy link
Copy Markdown
Contributor

@jogeo jogeo commented Apr 9, 2026

Adds a 4.22 compare view between HA and Two Node with Arbiter clusters.

Summary by CodeRabbit

  • Chores
    • Added a new component readiness configuration for release 4.22 to compare HA vs two-node-arbiter topologies, including variant filters (architecture, feature set, installer, job tier, layered product, owner, platform, cgroup mode, container runtime) and lifecycle test filtering.
    • Configured advanced thresholds and regression tracking; metrics collection disabled.
    • Restricted an existing 4.22 fencing entry to platform "metal" only.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 33e687ab-a8fa-4a15-9eb0-10e637bc4308

📥 Commits

Reviewing files that changed from the base of the PR and between 8a8cd2b and e910bfc.

📒 Files selected for processing (1)
  • config/views.yaml

Walkthrough

Added a new component_readiness entry 4.22-ha-vs-two-node-arbiter to config/views.yaml and updated the existing 4.22-ha-vs-two-node-fencing entry to restrict its Platform to metal.

Changes

Cohort / File(s) Summary
New Component Readiness entry
config/views.yaml
Added component_readiness.4.22-ha-vs-two-node-arbiter with a 7-day window, base_release/sample_release set to 4.22, variant cross-compare on Topology: two-node-arbiter, include_variants restricted (Architecture: amd64; FeatureSet: default,techpreview; Installer: ipi,upi; JobTier: blocking,informing,standard,candidate; LayeredProduct: none,virt; Owner: eng; Platform: metal; Topology: ha; CGroupMode: v2; ContainerRuntime: runc,crun), test_filters.lifecycles: [blocking], advanced_options (minimum_failure: 3, confidence: 95, pity_factor: 5, ignore_missing: false, ignore_disruption: true, flake_as_failure: false), metrics.enabled: false, and regression_tracking.enabled: true.
Modified Component Readiness entry
config/views.yaml
Updated component_readiness.4.22-ha-vs-two-node-fencing to remove Platform values aws, azure, gcp, and vsphere, leaving Platform: metal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Go Error Handling ✅ Passed The custom check for Go Error Handling does not apply as changes are exclusively in YAML configuration file with no Go source code modifications.
Sql Injection Prevention ✅ Passed Configuration-only changes to views.yaml use GORM ORM with parameterized queries, ensuring no SQL injection vulnerabilities are introduced.
Excessive Css In React Should Use Styles ✅ Passed This PR modifies only config/views.yaml with no React component code changes, making the useStyles pattern check not applicable.
Single Responsibility And Clear Naming ✅ Passed Custom check for Single Responsibility and Clear Naming is not applicable to this PR as it only modifies YAML configuration files, not code architecture elements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from smg247 and stbenjam April 9, 2026 16:50
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@jogeo
Copy link
Copy Markdown
Contributor Author

jogeo commented Apr 10, 2026

/retest

@jaypoulz
Copy link
Copy Markdown

jaypoulz commented Apr 10, 2026

As part of this change, can you limit the view to just "metal" platform? (For both TNF and TNA)

@eggfoobar
Copy link
Copy Markdown
Contributor

eggfoobar commented Apr 10, 2026

This might be a silly question, but should we combine these as ha-vs-two-node? Since we can specify multiple topologies in a view we can just have a 3 column compare between HA metal and TNF/TNA in one view?

@jaypoulz
Copy link
Copy Markdown

This might be a silly question, but should we combine these as ha-vs-two-node? Since we can specify multiple topologies in a view we can just have a 3 column compare between HA metal and TNF/TNA in one view?

@eggfoobar would the regression list show regressions for both? I lean towards seperate because I know what that would look like. I'm fine with HA vs Two-Node if it still possible to see regressions between HA and TNF plus HA and TNA, but I don't know if that would be the result of that.

@jogeo
Copy link
Copy Markdown
Contributor Author

jogeo commented Apr 10, 2026

@eggfoobar The goal of these views is to help us show stability of TNA (and TNF) jobs. Once stable, they will be added to the main CR view. Therefore, I suggest we do not tie them together, as moving one to the main view will not depend on the other.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

Copy link
Copy Markdown

@jaypoulz jaypoulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026
@jogeo
Copy link
Copy Markdown
Contributor Author

jogeo commented Apr 10, 2026

/approve

@dgoodwin
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, jaypoulz, jogeo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

@jogeo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9c8b736 into openshift:main Apr 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants