Add 4.22-ha-vs-two-node-arbiter view.#3422
Add 4.22-ha-vs-two-node-arbiter view.#3422openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdded a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Scheduling required tests: |
|
/retest |
|
As part of this change, can you limit the view to just "metal" platform? (For both TNF and TNA) |
|
This might be a silly question, but should we combine these as |
@eggfoobar would the regression list show regressions for both? I lean towards seperate because I know what that would look like. I'm fine with HA vs Two-Node if it still possible to see regressions between HA and TNF plus HA and TNA, but I don't know if that would be the result of that. |
|
@eggfoobar The goal of these views is to help us show stability of TNA (and TNF) jobs. Once stable, they will be added to the main CR view. Therefore, I suggest we do not tie them together, as moving one to the main view will not depend on the other. |
|
Scheduling required tests: |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, jaypoulz, jogeo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jogeo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Adds a 4.22 compare view between HA and Two Node with Arbiter clusters.
Summary by CodeRabbit