Skip to content

[ote] Add windows-ote-setup step for WMCO non-payload OTE binary#77555

Open
weinliu wants to merge 1 commit intoopenshift:mainfrom
weinliu:WINC-1777-ote-setup-step
Open

[ote] Add windows-ote-setup step for WMCO non-payload OTE binary#77555
weinliu wants to merge 1 commit intoopenshift:mainfrom
weinliu:WINC-1777-ote-setup-step

Conversation

@weinliu
Copy link
Copy Markdown
Contributor

@weinliu weinliu commented Apr 8, 2026

Summary

WMCO is an OLM optional operator (not CVO-managed payload), so the standard payload-based OTE binary registration in binary.go does not apply (see openshift/origin#30945 which was closed for this reason).

This PR adds a new windows-ote-setup step that implements the non-payload OTE binary mechanism introduced in openshift/origin#30863 (TestExtensionAdmission CRD + ImageStreamTag annotations).

What the step does

When run after WMCO is deployed on a cluster:

  1. Creates an ImageStream (wmco-ote) in the WMCO namespace pointing to the CI image (built from Dockerfile.ci, which includes /usr/bin/wmco-tests-ext.gz)
  2. Annotates the ImageStreamTag with testextension.redhat.io/component and testextension.redhat.io/binary for OTE discovery
  3. Installs the TestExtensionAdmission CRD
  4. Creates a TestExtensionAdmission CR permitting the WMCO namespace

After this step, openshift-tests will automatically discover and execute the WMCO OTE binary via the non-payload mechanism.

Usage

Add windows-ote-setup to the test: section of WMCO e2e workflows, before any openshift-tests run step:

test:
- ref: windows-ote-setup
- ref: <openshift-tests-run-step>

Related

@openshift-ci openshift-ci bot requested review from jrvaldes and juzhao April 8, 2026 16:51
@weinliu weinliu force-pushed the WINC-1777-ote-setup-step branch from a70d1f0 to bfcbcf7 Compare April 8, 2026 16:54
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 8, 2026
@weinliu weinliu force-pushed the WINC-1777-ote-setup-step branch from bfcbcf7 to 08dced3 Compare April 8, 2026 16:56
@weinliu
Copy link
Copy Markdown
Contributor Author

weinliu commented Apr 8, 2026

/pj-rehearse aws-e2e-operator

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@weinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weinliu
Once this PR has been reviewed and has the lgtm label, please assign mansikulkarni96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@weinliu: job(s): aws-e2e-operator either don't exist or were not found to be affected, and cannot be rehearsed

@weinliu weinliu force-pushed the WINC-1777-ote-setup-step branch 2 times, most recently from 9211336 to db1cb6f Compare April 8, 2026 17:19
@weinliu
Copy link
Copy Markdown
Contributor Author

weinliu commented Apr 8, 2026

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-operator

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@weinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

WMCO is an OLM optional operator (not CVO-managed payload), so the
standard payload-based OTE binary registration does not apply.

This step implements the non-payload OTE binary mechanism introduced in
openshift/origin#30863 (TestExtensionAdmission CRD + ImageStreamTag
annotations). When run after WMCO is deployed:

1. Creates an ImageStream in the WMCO namespace pointing to the CI image
   (built from Dockerfile.ci, which includes wmco-tests-ext.gz)
2. Annotates the ImageStreamTag with testextension.redhat.io/component
   and testextension.redhat.io/binary for OTE discovery
3. Installs the TestExtensionAdmission CRD
4. Creates a TestExtensionAdmission CR permitting the WMCO namespace

Added to aws-e2e-operator job to enable rehearsal testing.

Related: WINC-1777, OCP-37362
@weinliu weinliu force-pushed the WINC-1777-ote-setup-step branch from db1cb6f to ac56bab Compare April 8, 2026 21:35
@weinliu
Copy link
Copy Markdown
Contributor Author

weinliu commented Apr 8, 2026

/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-operator

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@weinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@weinliu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-operator openshift/windows-machine-config-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

@weinliu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants