[release-4.20] OCPBUGS-81484: CUDN: cleanup NADs in terminating namespaces without pods by kyrtapz · Pull Request #3102 · openshift/ovn-kubernetes

kyrtapz · 2026-03-31T10:54:07Z

Skip namespaces with deletionTimestamp set when selecting target namespaces, triggering NAD deletion for terminating namespaces.

Manual, clean cherry-pick.
(cherry picked from commit 7606fd8)

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation
if so, I have updated the documentation as required
My code requires tests
if so, I have added and/or updated the tests as required
All the tests have passed in the CI

How to verify it

coderabbitai · 2026-03-31T10:54:16Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: f8254439-fe33-4270-b4b9-ab35089ad4fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Note

`.coderabbit.yml` has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'paths_ignore'

⚙️ Configuration instructions

Please see the configuration documentation for more information.
You can also validate your configuration using the online YAML validator.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-03-31T11:03:31Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-81484, which is invalid:

expected the bug to target the "4.20.z" version, but no target version was set
expected Jira Issue OCPBUGS-81484 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Skip namespaces with deletionTimestamp set when selecting target namespaces, triggering NAD deletion for terminating namespaces.

(cherry picked from commit a61b7457eff1bbda01a91ec268a6c90221b9e54a)

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kyrtapz · 2026-03-31T11:08:46Z

/jira refresh

openshift-ci-robot · 2026-03-31T11:08:52Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-81484, which is invalid:

expected the bug to target the "4.20.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kyrtapz · 2026-03-31T11:09:17Z

/jira refresh

openshift-ci-robot · 2026-03-31T11:09:25Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-81484, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-81485 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-81485 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Skip namespaces with deletionTimestamp set when selecting target namespaces, triggering NAD deletion for terminating namespaces. Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit 7606fd8)

openshift-ci-robot · 2026-03-31T11:16:15Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-81484, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-81485 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-81485 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

Details

In response to this:

Skip namespaces with deletionTimestamp set when selecting target namespaces, triggering NAD deletion for terminating namespaces.

Manual, clean cherry-pick.
(cherry picked from commit 7606fd8)

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

My code requires changes to the documentation

if so, I have updated the documentation as required

My code requires tests

if so, I have added and/or updated the tests as required

All the tests have passed in the CI

How to verify it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kyrtapz · 2026-03-31T11:16:28Z

/hold
we need to wait for #3087 to land in 4.21

pliurh · 2026-03-31T13:58:09Z

/lgtm

openshift-ci · 2026-03-31T14:00:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, pliurh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pliurh · 2026-04-01T02:30:49Z

/retest-required

pliurh · 2026-04-01T07:36:02Z

/retest-required

openshift-ci · 2026-04-01T08:57:41Z

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-techpreview	`20b802c`	link	true	`/test e2e-gcp-ovn-techpreview`
ci/prow/e2e-aws-ovn-edge-zones	`20b802c`	link	true	`/test e2e-aws-ovn-edge-zones`
ci/prow/security	`20b802c`	link	false	`/test security`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot requested review from jcaamano and martinkennelly March 31, 2026 10:55

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026

kyrtapz changed the title ~~CUDN: cleanup NADs in terminating namespaces without pods~~ OCPBUGS-81484: CUDN: cleanup NADs in terminating namespaces without pods Mar 31, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 31, 2026

kyrtapz changed the title ~~OCPBUGS-81484: CUDN: cleanup NADs in terminating namespaces without pods~~ [release-4.20] OCPBUGS-81484: CUDN: cleanup NADs in terminating namespaces without pods Mar 31, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 31, 2026

CUDN: cleanup NADs in terminating namespaces without pods

20b802c

Skip namespaces with deletionTimestamp set when selecting target namespaces, triggering NAD deletion for terminating namespaces. Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit 7606fd8)

kyrtapz force-pushed the cudn_ns_cleanup_fix branch from 25f00e9 to 20b802c Compare March 31, 2026 11:15

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2026

openshift-ci bot assigned pliurh Mar 31, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026

Conversation

kyrtapz commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

coderabbitai bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

.coderabbit.yml has unrecognized properties

Uh oh!

openshift-ci-robot commented Mar 31, 2026

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

kyrtapz commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

kyrtapz commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

📑 Description

Additional Information for reviewers

✅ Checks

How to verify it

Uh oh!

kyrtapz commented Mar 31, 2026

Uh oh!

pliurh commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

pliurh commented Apr 1, 2026

Uh oh!

pliurh commented Apr 1, 2026

Uh oh!

openshift-ci bot commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kyrtapz commented Mar 31, 2026 •

edited

Loading

coderabbitai bot commented Mar 31, 2026 •

edited

Loading

`.coderabbit.yml` has unrecognized properties