Skip to content

OCPBUGS-63307: Fix image policy event intervals and bookkeeping#30991

Open
haircommander wants to merge 1 commit intoopenshift:mainfrom
haircommander:image-policy-intervals
Open

OCPBUGS-63307: Fix image policy event intervals and bookkeeping#30991
haircommander wants to merge 1 commit intoopenshift:mainfrom
haircommander:image-policy-intervals

Conversation

@haircommander
Copy link
Copy Markdown
Member

@haircommander haircommander commented Apr 9, 2026

Assisted by Claude.

All of the other intervals are around 10 minutes. These events are triggered by MCP rollout, which happens for each of the image policy tests.
10 minutes is actually on the lower end for MCP rollout (which is given 20 minutes before timing out), but let's start with this and increase
in the future if necessary

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 9, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@haircommander: This pull request references Jira Issue OCPBUGS-63307, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Assisted by Claude.

There are two changes here, more details in each commit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4a3c7f35-0ac0-4431-92af-cd050b430112

📥 Commits

Reviewing files that changed from the base of the PR and between 46ee5b7 and 960bfdf.

📒 Files selected for processing (1)
  • pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

Walkthrough

Three event matcher functions in the pathological event library were modified to increase their buffered overlap windows from ±30 seconds to ±20 minutes and a blank line was added after each Filter(...) block; no other logic was changed.

Changes

Cohort / File(s) Summary
Overlap window adjustments
pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
Updated three matcher functions (newConfigDriftMonitorStoppedTooOftenEventMatcher, newAddSigtermProtectionEventMatcher, newRemoveSigtermProtectionEventMatcher) to widen overlap windows from ±30 seconds to ±20 minutes by changing Add() on interval bounds. Added a blank line after each Filter(...) block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from deads2k and sjenning April 9, 2026 19:35
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@cpmeadors
Copy link
Copy Markdown
Contributor

The increase the intervals commit looks good. Waiting on possible rework on the deferclean up commit.

@haircommander haircommander force-pushed the image-policy-intervals branch from 248685a to 46ee5b7 Compare April 9, 2026 20:34
@cpmeadors
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpmeadors, haircommander
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpmeadors, haircommander
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

@haircommander: This pull request references Jira Issue OCPBUGS-63307, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Assisted by Claude.

All of the other intervals are around 10 minutes. These events are triggered by MCP rollout, which happens for each of the image policy tests.
10 minutes is actually on the lower end for MCP rollout (which is given 20 minutes before timing out), but let's start with this and increase
in the future if necessary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips 46ee5b7 link true /test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BhargaviGudi
Copy link
Copy Markdown
Contributor

/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a488aa10-34b9-11f1-9ef8-5eddfc43811b-0

@BhargaviGudi
Copy link
Copy Markdown
Contributor

/payload-job periodic-ci-openshift-release-main-ci-4.21-e2e-azure-ovn-techpreview-serial

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.21-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b01b0170-34b9-11f1-8baa-b6739f6b7d46-0

@BhargaviGudi
Copy link
Copy Markdown
Contributor

BhargaviGudi commented Apr 10, 2026

Test case [Monitor:legacy-test-framework-invariants-pathological][sig-arch] events should not repeat pathologically is failing even with PR fix
periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial
periodic-ci-openshift-release-main-ci-4.21-e2e-azure-ovn-techpreview-serial

All of the other intervals are around 10 minutes. These events are triggered by MCP rollout, which happens for each of the image policy tests.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander haircommander force-pushed the image-policy-intervals branch from 46ee5b7 to 960bfdf Compare April 10, 2026 17:45
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

New changes are detected. LGTM label has been removed.

@haircommander
Copy link
Copy Markdown
Member Author

/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial
/payload-job periodic-ci-openshift-release-main-ci-4.21-e2e-azure-ovn-techpreview-serial

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

@haircommander: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-main-ci-4.21-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2d8c3cf0-3505-11f1-9adb-e9ec8aa322fd-0

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants