daemon: Explicitly start rpm-ostreed, restart if we detect active txn

[cgwalters]

This is a workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1982389
which is already fixed in rpm-ostree in
coreos/rpm-ostree#2995
because it will take a fair while until we can ship the fixed
rpm-ostreed in RHEL and then OpenShift stable versions.
(Yes, this is a sad recurring pattern)

The updater client gains an explicit Initialize method, where
we also explicitly systemctl start rpm-ostreed which
then effectively rolls in the change from
coreos/rpm-ostree#2945
too.

[kikisdeliveryservice]

Two questions :)

[kikisdeliveryservice]

Thanks Colin!

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, kikisdeliveryservice, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@cgwalters: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-upgrade-single-node	8c87cac	link	/test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-workers-rhel7	8c87cac	link	/test e2e-aws-workers-rhel7
ci/prow/e2e-ovn-step-registry	8c87cac	link	/test e2e-ovn-step-registry
ci/prow/e2e-metal-ipi	8c87cac	link	/test e2e-metal-ipi
ci/prow/e2e-vsphere-upgrade	8c87cac	link	/test e2e-vsphere-upgrade
ci/prow/e2e-aws-disruptive	8c87cac	link	/test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[cgwalters]

/cherrypick release-4.8

[openshift-cherrypick-robot]

@cgwalters: #2677 failed to apply on top of branch "release-4.8":

Applying: daemon: Explicitly start rpm-ostreed, restart if we detect active txn
Using index info to reconstruct a base tree...
M	pkg/daemon/daemon.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/daemon/daemon.go
CONFLICT (content): Merge conflict in pkg/daemon/daemon.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 daemon: Explicitly start rpm-ostreed, restart if we detect active txn
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.