Skip to content

STOR-2758: Rebase to upstream v6.2.0 for OCP 4.22#121

Merged
openshift-merge-bot[bot] merged 42 commits intoopenshift:masterfrom
dfajmon:rebase-v6.2.0
Mar 11, 2026
Merged

STOR-2758: Rebase to upstream v6.2.0 for OCP 4.22#121
openshift-merge-bot[bot] merged 42 commits intoopenshift:masterfrom
dfajmon:rebase-v6.2.0

Conversation

@dfajmon
Copy link
Copy Markdown

@dfajmon dfajmon commented Mar 9, 2026

Issue link
https://issues.redhat.com/browse/STOR-2758

Diff to upstream v6.2.0
kubernetes-csi/external-provisioner@v6.2.0...dfajmon:rebase-v6.2.0

Notes for reviewers

Summary of changes

Major Features

  • A StorageClass can use csi.storage.k8s.io/controller-modify-secret-name and csi.storage.k8s.io/controller-modify-secret-namespace to reference the credentials that should be used to modify a volume according to the parameters of a VolumeAttributeClass (#1440)
  • Add provisioner.storage.kubernetes.io/volumesnapshot-as-source-protection finalizer on VolumeSnapshot as Source. Add rbac rules to watch/update volumesnapshots. The external-provisioner is able to work without these new RBAC permissions, but we strongly encourage the CSI driver vendors to update them (#1458)

Notable Bug Fixes

  • Fixed infinite retry loop during provisioning if node was deleted in the meantime (#1438)
  • Allow provisioning to proceed when snapshot is being deleted to prevent leaking volumes and snapshots (#1448)
  • Fixed a bug where retries could cause volumes to be provisioned in the wrong availability zone (#1466)

CVE Fixes

CVE-2025-68121

Upstream changelogs

Full changelog

kubernetes-csi/external-provisioner@v6.0.0...v6.2.0

Last rebase

#117

@openshift/storage

dependabot Bot and others added 30 commits September 29, 2025 05:28
Bumps [github.com/mailru/easyjson](https://github.com/mailru/easyjson) from 0.9.0 to 0.9.1.
- [Release notes](https://github.com/mailru/easyjson/releases)
- [Commits](mailru/easyjson@v0.9...v0.9.1)

---
updated-dependencies:
- dependency-name: github.com/mailru/easyjson
  dependency-version: 0.9.1
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
GenerateAccessibilityRequirements tries to get the Node and CSINode objects but if they are missing (because they were deleted), then the provisioning will fail with ProvisioningNoChange which means that it will potentially be retried forever if the node never comes back because nothing is removing the selected-node annotation anymore.
This commit makes it so that Not Found api errors are properly caught and when it's the case, ProvisioningReschedule is returned to tell the scheduler to try a new node.
This matches the previous implementation in the external-provisioner lib (https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/194/files#diff-3c5bb5f48211873c58fcba055dcae2ac7b1958969219e06e1508d76d485dace7L1496-L1498)

Signed-off-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com>
The ControllerModifyVolume CSI procedure should be able to receive
credentials if the storage provider requires them.

The values of the following keys in the StorageClass are copied into
annotations of the PersistentVolume:
 - csi.storage.k8s.io/controller-modify-secret-name
   > volume.kubernetes.io/controller-modify-secret-name
 - csi.storage.k8s.io/controller-modify-secret-namespace
   > volume.kubernetes.io/controller-modify-secret-namespace

The external-resizer can use these annotations to resolve the secret
that needs to be passed in ControllerModifyVolume.
…ule-node-not-exist

[controller] Reschedule provisioning if node is missing
Check for finalizers on VolumeSnapshot to differentiate between
provisioning that has already started vs new provisioning attempts.

When a VolumeSnapshot has DeletionTimestamp set:
- If it has finalizers: provisioning was started before deletion,
  continue to prevent resource leaks. The external-snapshotter adds
  finalizers when a snapshot is used as a data source.
- If it has no finalizers: this is a new provisioning attempt,
  reject with an error.

This ensures the CSI driver can complete in-flight provisioning
operations and properly clean up resources, while preventing new
provisioning from snapshots that are being deleted.
Allow provisioning to proceed to prevent leaking resources
…tools/k8s-1.34

Update to latest release-tools to address Docker and Kind deployment
failures.
b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d9 Add myself as csi approver
c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981a Bump actions/checkout from 5 to 6
294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6
fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs

git-subtree-dir: release-tools
git-subtree-split: b12e407cc9556acf6702ed8745d3f8a29c9169bb
…s-1.34

Rebase release-tools to use Kubernetes v1.34 by default
Add secret reference in PV annotations for ControllerModifyVolume
…lake

Fix provisioner flake in topology tests
Add a finalizer on VolumeSnapshot as Source
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 6.0.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5.0.0...v6.0.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Eddie Torres <torredil@amazon.com>
…/github_actions/actions/checkout-6.0.2

build(deps): bump actions/checkout from 5.0.0 to 6.0.2
…/go_modules/github.com/mailru/easyjson-0.9.1

build(deps): bump github.com/mailru/easyjson from 0.9.0 to 0.9.1
Fix topology cache corruption on retry
1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9
4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727
b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8
0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE
707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck
a9d2b0fb3 Bump logcheck to v0.10.0
d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c49 Bump golang to 1.25.5

git-subtree-dir: release-tools
git-subtree-split: 1e81e752e87e027311be882279eac9e292705aa5
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 9, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 9, 2026

@dfajmon: This pull request references STOR-2758 which is a valid jira issue.

Details

In response to this:

Issue link
https://issues.redhat.com/browse/STOR-2758

Diff to upstream v6.2.0
kubernetes-csi/external-provisioner@v6.2.0...dfajmon:rebase-v6.2.0

Notes for reviewers

Summary of changes

Major Features

  • A StorageClass can use csi.storage.k8s.io/controller-modify-secret-name and csi.storage.k8s.io/controller-modify-secret-namespace to reference the credentials that should be used to modify a volume according to the parameters of a VolumeAttributeClass (#1440)
  • Add provisioner.storage.kubernetes.io/volumesnapshot-as-source-protection finalizer on VolumeSnapshot as Source. Add rbac rules to watch/update volumesnapshots. The external-provisioner is able to work without these new RBAC permissions, but we strongly encourage the CSI driver vendors to update them (#1458)

Notable Bug Fixes

  • Fixed infinite retry loop during provisioning if node was deleted in the meantime (#1438)
  • Allow provisioning to proceed when snapshot is being deleted to prevent leaking volumes and snapshots (#1448)
  • Fixed a bug where retries could cause volumes to be provisioned in the wrong availability zone (#1466)

CVE Fixes

CVE-2025-68121

Upstream changelogs

Full changelog

kubernetes-csi/external-provisioner@v6.0.0...v6.2.0

Last rebase

#117

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from dobsonj and rhrmo March 9, 2026 10:28
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2026
@dfajmon
Copy link
Copy Markdown
Author

dfajmon commented Mar 9, 2026

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 9, 2026

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Comment thread deploy/kubernetes/rbac.yaml
@jsafrane
Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2026
@duanwei33
Copy link
Copy Markdown

CI results look good, which should be sufficient for merging from QE side.
/verified by @duanwei33

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 11, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@duanwei33: This PR has been marked as verified by @duanwei33.

Details

In response to this:

CI results look good, which should be sufficient for merging from QE side.
/verified by @duanwei33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit f90c06a into openshift:master Mar 11, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.