OCPBUGS-83406 OCPBUGS-83407: fix issue for managed mode of no-overlay

[arghosh93]

there are two issues for no-overlay managed routing mode:

With -p 0, the BGP daemon does not listen for incoming connections, which breaks the full-mesh iBGP topology used in managed routing mode. Each node must be able to accept BGP sessions from all other nodes, requiring the standard port 179 to be active.

When no-overlay transport is configured with managed routing (NoOverlayManagedEnabled),
the ovn-kubernetes-control-plane service account runs the managed BGP controller which
needs to create, delete, patch and update RouteAdvertisements CRs. The existing
OVN_ROUTE_ADVERTISEMENTS_ENABLE block only grants list/get/watch, causing the cluster
manager to fail on startup with a forbidden error.

cherry-picked from #2954

Summary by CodeRabbit

• New Features
  • Enabled BGP daemon to accept incoming BGP sessions on port 179 when managed overlay routing is configured
  • Added control plane permissions for route advertisement management in managed overlay deployments

[openshift-ci-robot]

@arghosh93: This pull request references CORENET-6953 which is a valid jira issue.

This pull request references CORENET-6951 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

there are two issues for no-overlay managed routing mode:

With -p 0, the BGP daemon does not listen for incoming connections, which breaks the full-mesh iBGP topology used in managed routing mode. Each node must be able to accept BGP sessions from all other nodes, requiring the standard port 179 to be active.

When no-overlay transport is configured with managed routing (NoOverlayManagedEnabled),
the ovn-kubernetes-control-plane service account runs the managed BGP controller which
needs to create, delete, patch and update RouteAdvertisements CRs. The existing
OVN_ROUTE_ADVERTISEMENTS_ENABLE block only grants list/get/watch, causing the cluster
manager to fail on startup with a forbidden error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The changes introduce a new template data field NoOverlayManagedEnabled that conditionally controls FRR BGP daemon port behavior and Kubernetes RBAC permissions. When overlay-managed routing is enabled, the BGP daemon listens on port 179 for incoming connections; otherwise it uses port 0. New RBAC rules grant route advertisement permissions when the flag is enabled.

Changes

Cohort / File(s)	Summary
FRR Configuration bindata/network/frr-k8s/config.yaml	Updated BGP daemon startup options to conditionally set listen-port: port 179 when NoOverlayManagedEnabled is true (accepting BGP sessions for managed iBGP topology), otherwise port 0. Includes inline comments explaining the behavior.
Kubernetes RBAC bindata/network/ovn-kubernetes/common/004-rbac-control-plane.yaml	Normalized YAML formatting for apiGroups mapping. Added conditional ClusterRole rule gated by NoOverlayManagedEnabled that grants control-plane permissions (create, delete, patch, update) on k8s.ovn.org routeadvertisements resources.
Go Rendering Logic pkg/network/render.go	Modified renderAdditionalRoutingCapabilities() to compute and pass NoOverlayManagedEnabled field to FRR template context. Field is enabled when OVNKubernetesConfig exists and BGPTopology is a non-empty string.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 9 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (9 passed)

Check name	Status	Explanation
Stable And Deterministic Test Names	✅ Passed	PR contains no Ginkgo test files or test definitions. Changes limited to two YAML configs and one Go source file with no test code.
Test Structure And Quality	✅ Passed	The custom check for test structure and quality is not applicable to this PR. No test files (*_test.go) were modified.
Microshift Test Compatibility	✅ Passed	This pull request does not add any new Ginkgo e2e tests. The PR only modifies configuration files and template rendering logic. Since no new Ginkgo test methods are being introduced, the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request modifies configuration files and Go source code but does not add any new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility	✅ Passed	Changes to BGP configuration, RBAC permissions, and rendering logic do not introduce scheduling constraints that would break SNO or multi-node topologies.
Ote Binary Stdout Contract	✅ Passed	Changes are limited to YAML configuration files and configuration rendering logic with no stdout writes in process-level code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests; modified files are configuration and source code without test patterns.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the two Jira issues (OCPBUGS-83406 OCPBUGS-83407) and clearly indicates the purpose: fixing issues for managed mode of no-overlay routing, which aligns with the changeset's modifications to BGP port configuration and RBAC permissions.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arghosh93
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@arghosh93: This pull request references CORENET-6953 which is a valid jira issue.

This pull request references CORENET-6951 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

there are two issues for no-overlay managed routing mode:

With -p 0, the BGP daemon does not listen for incoming connections, which breaks the full-mesh iBGP topology used in managed routing mode. Each node must be able to accept BGP sessions from all other nodes, requiring the standard port 179 to be active.

When no-overlay transport is configured with managed routing (NoOverlayManagedEnabled),
the ovn-kubernetes-control-plane service account runs the managed BGP controller which
needs to create, delete, patch and update RouteAdvertisements CRs. The existing
OVN_ROUTE_ADVERTISEMENTS_ENABLE block only grants list/get/watch, causing the cluster
manager to fail on startup with a forbidden error.

Summary by CodeRabbit

• New Features
• Enabled BGP daemon to accept incoming BGP sessions on port 179 when managed overlay routing is configured
• Added control plane permissions for route advertisement management in managed overlay deployments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@arghosh93: This pull request references CORENET-6953 which is a valid jira issue.

This pull request references CORENET-6951 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

there are two issues for no-overlay managed routing mode:

With -p 0, the BGP daemon does not listen for incoming connections, which breaks the full-mesh iBGP topology used in managed routing mode. Each node must be able to accept BGP sessions from all other nodes, requiring the standard port 179 to be active.

When no-overlay transport is configured with managed routing (NoOverlayManagedEnabled),
the ovn-kubernetes-control-plane service account runs the managed BGP controller which
needs to create, delete, patch and update RouteAdvertisements CRs. The existing
OVN_ROUTE_ADVERTISEMENTS_ENABLE block only grants list/get/watch, causing the cluster
manager to fail on startup with a forbidden error.

cherry-picked from #2954

Summary by CodeRabbit

• New Features
• Enabled BGP daemon to accept incoming BGP sessions on port 179 when managed overlay routing is configured
• Added control plane permissions for route advertisement management in managed overlay deployments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[arghosh93]

/retitle OCPBUGS-83406 OCPBUGS-83407: fix issue for managed mode of no-overlay

[openshift-ci-robot]

@arghosh93: This pull request references Jira Issue OCPBUGS-83406, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-83407, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

there are two issues for no-overlay managed routing mode:

With -p 0, the BGP daemon does not listen for incoming connections, which breaks the full-mesh iBGP topology used in managed routing mode. Each node must be able to accept BGP sessions from all other nodes, requiring the standard port 179 to be active.

When no-overlay transport is configured with managed routing (NoOverlayManagedEnabled),
the ovn-kubernetes-control-plane service account runs the managed BGP controller which
needs to create, delete, patch and update RouteAdvertisements CRs. The existing
OVN_ROUTE_ADVERTISEMENTS_ENABLE block only grants list/get/watch, causing the cluster
manager to fail on startup with a forbidden error.

cherry-picked from #2954

Summary by CodeRabbit

• New Features
• Enabled BGP daemon to accept incoming BGP sessions on port 179 when managed overlay routing is configured
• Added control plane permissions for route advertisement management in managed overlay deployments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[arghosh93]

/retest

[arghosh93]

/jira refresh

[openshift-ci-robot]

@arghosh93: This pull request references Jira Issue OCPBUGS-83406, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-83407, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[arghosh93]

/retest

[openshift-ci]

@arghosh93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec	c82594d	link	true	/test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-ovn-ipsec-step-registry	c82594d	link	true	/test e2e-ovn-ipsec-step-registry
ci/prow/e2e-azure-ovn-upgrade	c82594d	link	true	/test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade	c82594d	link	true	/test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6	c82594d	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/security	c82594d	link	false	/test security
ci/prow/e2e-aws-ovn-hypershift-conformance	c82594d	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-gcp-ovn	c82594d	link	true	/test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw	c82594d	link	true	/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp	c82594d	link	true	/test e2e-metal-ipi-ovn-dualstack-bgp
ci/prow/e2e-aws-ovn-rhcos10-techpreview	c82594d	link	false	/test e2e-aws-ovn-rhcos10-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.