OCPBUGS-82973: align frr-k8s 25/3/2026 by oribon · Pull Request #2945 · openshift/cluster-network-operator

oribon · 2026-03-25T17:20:43Z

Aligning the frr-k8s manifests with openshift/frr#128, the 2 major changes are:

frr-k8s no longer uses kube-rbac-proxy but rather exposes the https endpoints directly, aligning the bits with upstream
new crd introduced
the 2 other commits are for e2e passing downstream, as upstream has these assumptions already baked in

frr-k8s no longer uses kube-rbac-proxy, but instead exposes the TLS endpoints directly. The TLS parameters (fed by OCP TLS Profile) should be passed as flags to the frr-k8s binaries, to be done in a seperate commit. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com> Assisted-by: Cursor

coderabbitai · 2026-03-25T17:20:51Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 29807521-515d-4d4c-915b-0855a336f18f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

oribon · 2026-03-25T17:22:02Z

/testwith openshift/cluster-network-operator/master/frrk8s-e2e openshift/frr#128

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>

We have e2es that rely on the poll-interval being low, here we add a support to modify it through the configmap, to be set by CI lanes. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com> Assisted-by: Cursor

oribon · 2026-03-30T08:17:15Z

/testwith openshift/cluster-network-operator/master/frrk8s-e2e openshift/frr#128

andreaskaris · 2026-03-30T09:52:57Z

I didn't do a super thorough review. however subject to passing
/lgtm

openshift-ci · 2026-03-30T09:53:17Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andreaskaris, oribon
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-03-30T14:25:10Z

New changes are detected. LGTM label has been removed.

andreaskaris · 2026-03-30T14:52:09Z

/testwith openshift/cluster-network-operator/master/frrk8s-e2e openshift/frr#128

We missed this binary when introducing the configmap Signed-off-by: Ori Braunshtein <obraunsh@redhat.com> Changes to be committed:

oribon · 2026-03-31T07:42:58Z

/testwith openshift/cluster-network-operator/master/frrk8s-e2e openshift/frr#128

oribon · 2026-03-31T11:44:35Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp openshift/frr#128

oribon · 2026-03-31T12:19:16Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128

openshift-ci · 2026-03-31T12:55:49Z

@oribon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ovn-ipsec-step-registry	`f9c3dc6`	link	true	`/test e2e-ovn-ipsec-step-registry`
ci/prow/security	`f9c3dc6`	link	false	`/test security`
ci/prow/4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade	`f9c3dc6`	link	false	`/test 4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade`
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp	`f9c3dc6`	link	true	`/test e2e-metal-ipi-ovn-dualstack-bgp`
ci/prow/frrk8s-e2e	`f9c3dc6`	link	false	`/test frrk8s-e2e`
ci/prow/e2e-aws-ovn-serial-2of2	`f9c3dc6`	link	true	`/test e2e-aws-ovn-serial-2of2`
ci/prow/e2e-aws-ovn-rhcos10-techpreview	`f9c3dc6`	link	false	`/test e2e-aws-ovn-rhcos10-techpreview`
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw	`f9c3dc6`	link	true	`/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

oribon · 2026-03-31T16:14:06Z

/hold

fedepaol · 2026-04-01T09:04:11Z

/testwith openshift/cluster-network-operator/master/frrk8s-e2e openshift/frr#128

fedepaol · 2026-04-01T09:48:46Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp

fedepaol · 2026-04-01T09:49:30Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp openshift/frr#128

openshift-ci · 2026-04-01T09:49:34Z

@fedepaol, testwith: Error processing request. ERROR:

could not determine job runs: invalid format for additional PR: openshift/frr#128https://github.com/openshift/frr/pull/128

fedepaol · 2026-04-01T09:50:50Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp openshift/frr#128

fedepaol · 2026-04-01T09:55:17Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128

fedepaol · 2026-04-08T10:10:06Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp openshift/frr#128

fedepaol · 2026-04-10T08:08:56Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128

oribon · 2026-04-13T07:54:10Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128

openshift-ci-robot · 2026-04-13T08:05:59Z

@oribon: This pull request references Jira Issue OCPBUGS-82973, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Aligning the frr-k8s manifests with openshift/frr#128, the 2 major changes are:

frr-k8s no longer uses kube-rbac-proxy but rather exposes the https endpoints directly, aligning the bits with upstream

new crd introduced
the 2 other commits are for e2e passing downstream, as upstream has these assumptions already baked in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

oribon · 2026-04-14T08:58:27Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128

oribon · 2026-04-14T13:58:19Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128

oribon · 2026-04-14T18:44:12Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128

oribon · 2026-04-15T07:18:46Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128

oribon · 2026-04-15T15:18:05Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128

tried multiple times to run the localgw lane, it seems it has regressed with a lot of unrelated failures. the last couple of times didn't have any fail related to frr-k8s (I think), this is the last decent run (apr 13) https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-cluster-network-operator-2945-openshift-frr-128-e2e-metal-ipi-ovn-dualstack-bgp-local-gw/2043598631876956160

oribon · 2026-04-15T15:22:31Z

/testwith openshift/cluster-network-operator/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw openshift/frr#128

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026

openshift-ci bot requested review from arghosh93 and kyrtapz March 25, 2026 17:23

oribon added 2 commits March 25, 2026 19:38

Align frr-k8s manifests with frrk8sconfiguration

4c440ef

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>

frr-k8s: support specifying poll-interval

85820d3

We have e2es that rely on the poll-interval being low, here we add a support to modify it through the configmap, to be set by CI lanes. Signed-off-by: Ori Braunshtein <obraunsh@redhat.com> Assisted-by: Cursor

oribon force-pushed the frrk8s_tls_manifests branch from 9655f93 to 85820d3 Compare March 29, 2026 18:26

openshift-ci bot assigned andreaskaris Mar 30, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026

frr-k8s: pass log-level to status binary

f9c3dc6

We missed this binary when introducing the configmap Signed-off-by: Ori Braunshtein <obraunsh@redhat.com> Changes to be committed:

oribon force-pushed the frrk8s_tls_manifests branch from 4ebf872 to f9c3dc6 Compare March 31, 2026 07:42

oribon changed the title ~~WIP: align frr-k8s~~ align frr-k8s 25/3/2026 Mar 31, 2026

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2026

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2026

oribon mentioned this pull request Mar 31, 2026

OCPBUGS-82973: Sync 25-3-2026 openshift/frr#128

Merged

oribon changed the title ~~align frr-k8s 25/3/2026~~ OCPBUGS-82973: align frr-k8s 25/3/2026 Apr 13, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 13, 2026

Conversation

oribon commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

oribon commented Mar 25, 2026

Uh oh!

oribon commented Mar 30, 2026

Uh oh!

andreaskaris commented Mar 30, 2026

Uh oh!

openshift-ci bot commented Mar 30, 2026

Uh oh!

openshift-ci bot commented Mar 30, 2026

Uh oh!

andreaskaris commented Mar 30, 2026

Uh oh!

oribon commented Mar 31, 2026

Uh oh!

oribon commented Mar 31, 2026

Uh oh!

oribon commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

oribon commented Mar 31, 2026

Uh oh!

fedepaol commented Apr 1, 2026

Uh oh!

fedepaol commented Apr 1, 2026

Uh oh!

fedepaol commented Apr 1, 2026

Uh oh!

openshift-ci bot commented Apr 1, 2026

Uh oh!

fedepaol commented Apr 1, 2026

Uh oh!

fedepaol commented Apr 1, 2026

Uh oh!

fedepaol commented Apr 8, 2026

Uh oh!

fedepaol commented Apr 10, 2026

Uh oh!

oribon commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

oribon commented Apr 14, 2026

Uh oh!

oribon commented Apr 14, 2026

Uh oh!

oribon commented Apr 14, 2026

Uh oh!

oribon commented Apr 15, 2026

Uh oh!

oribon commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oribon commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oribon commented Mar 25, 2026 •

edited

Loading

coderabbitai bot commented Mar 25, 2026 •

edited

Loading

oribon commented Apr 15, 2026 •

edited

Loading