NE-2569: Promote Dynamic Configuration Manager to Default by Miciah · Pull Request #2788 · openshift/api

Miciah · 2026-03-31T21:06:12Z

Promote the IngressControllerDynamicConfigurationManager featuregate to the Default featureset.

This PR depends on openshift/origin#30926.

openshift-ci-robot · 2026-03-31T21:06:15Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2026-03-31T21:06:17Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2026-03-31T21:06:18Z

Hello @Miciah! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

coderabbitai · 2026-03-31T21:06:20Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 232b43cc-9c94-43af-9185-a1304842609f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Promote the IngressControllerDynamicConfigurationManager featuregate to the Default featureset. This commit resolves NE-2569. https://redhat.atlassian.net/browse/NE-2569 * features/features.go: Promote the featuregate to Default. * features.md: * operator/v1/zz_generated.crd-manifests/*: * payload-manifests/featuregates/*: Regenerate.

openshift-ci · 2026-03-31T21:06:28Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-03-31T21:07:00Z

@Miciah: This pull request references NE-2569 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Promote the IngressControllerDynamicConfigurationManager featuregate to the Default featureset.

This PR depends on openshift/origin#30926.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Miciah · 2026-03-31T21:07:46Z

/jira refresh

openshift-ci-robot · 2026-03-31T21:07:49Z

@Miciah: This pull request references NE-2569 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Miciah · 2026-04-01T15:05:31Z

/test lint
/test integration
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-crdify
/test verify-deps
/test verify-feature-promotion

qodo-code-review · 2026-04-01T15:07:50Z

PR-Agent: could not fine a component named lint in a supported language in this PR.

jcmoraisjr · 2026-04-01T16:38:21Z

/assign

bentito · 2026-04-01T21:19:58Z

/assign @jcmoraisjr

gcs278 · 2026-04-06T20:14:17Z

openshift/origin#30926 is merged:
/test verify-feature-promotion

gcs278 · 2026-04-07T13:55:06Z

Buried in the output is 0% passing on IPv6 clusters - openshift/origin#30972 should fix.

error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should handle scale-in operations [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should handle scale-in operations [Suite:openshift/conformance/parallel]" only passed 0%, need at least 95% for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should handle scale-out operations [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should handle scale-out operations [Suite:openshift/conformance/parallel]" only passed 0%, need at least 95% for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should handle various route updates [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should handle various route updates [Suite:openshift/conformance/parallel]" only passed 0%, need at least 95% for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should maintain proper balancing after scale-out and scale-in operations [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should maintain proper balancing after scale-out and scale-in operations [Suite:openshift/conformance/parallel]" only passed 0%, need at least 95% for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should maintain steady PID usage after scale-out and scale-in operations [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should maintain steady PID usage after scale-out and scale-in operations [Suite:openshift/conformance/parallel]" only passed 0%, need at least 95% for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should report accurate metrics after scale-out and scale-in operations [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should report accurate metrics after scale-out and scale-in operations [Suite:openshift/conformance/parallel]" only passed 0%, need at least 95% for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should work on basic functionalities [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}
error: "[sig-network-edge][Feature:Router][apigroup:route.openshift.io][OCPFeatureGate:IngressControllerDynamicConfigurationManager] The HAProxy router with Dynamic Config Manager should work on basic functionalities [Suite:openshift/conformance/parallel]" only passed 0%, need at least 95% for "IngressControllerDynamicConfigurationManager" on {metal amd64 ha ipv6   false}

gcs278 · 2026-04-07T13:59:50Z

I did the math you'll need 228 consecutive passes on metal IPv6 to get it back to 95% 😓

That's only ~114 test runs a day to get it in for Friday Branch Cut. That means you'll need to kick a test off every ~13 minutes (just kidding, don't do that).

@Miciah @jcmoraisjr Anyways, just a heads up, you'll likely have to advocate for an exception to get this in before branch cut.

Miciah · 2026-04-08T16:01:06Z

/test verify-feature-promotion

qodo-code-review · 2026-04-08T16:01:12Z

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

qodo-code-review · 2026-04-08T16:01:38Z

Review Summary by Qodo

Promote IngressControllerDynamicConfigurationManager featuregate to Default

✨ Enhancement

Walkthroughs

Description

• Promote IngressControllerDynamicConfigurationManager featuregate to Default
• Move feature from TechPreview to Default and OKD featuresets
• Update feature documentation and manifest files accordingly
• Regenerate CRD manifests to reflect new feature status

Diagram

flowchart LR
  A["IngressControllerDynamicConfigurationManager<br/>Feature Gate"] -->|"Promote from<br/>TechPreview"| B["Default Featureset"]
  A -->|"Add to"| C["OKD Featureset"]
  B -->|"Update"| D["Feature Documentation"]
  C -->|"Update"| D
  D -->|"Regenerate"| E["Manifest Files"]

File Changes

1. features/features.go ✨ Enhancement +1/-1

Enable feature in Default and OKD featuresets

features/features.go

2. features.md 📝 Documentation +1/-1

Move feature to Default featureset table

features.md

3. payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml ⚙️ Configuration changes +3/-3

Move feature from TechPreview to Default section

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

View more (8)

4. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml ⚙️ Configuration changes +3/-3

Move feature from TechPreview to Default section

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

5. payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml ⚙️ Configuration changes +3/-3

Move feature from TechPreview to Default section

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

6. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml ⚙️ Configuration changes +3/-3

Move feature from TechPreview to Default section

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

7. operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers.crd.yaml ⚙️ Configuration changes +0/-1

Regenerate CRD manifests for feature promotion

operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers.crd.yaml

8. operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers-Default.crd.yaml Additional files +0/-3286

...

operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers-Default.crd.yaml

9. operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers-DevPreviewNoUpgrade.crd.yaml Additional files +0/-3317

...

operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers-DevPreviewNoUpgrade.crd.yaml

10. operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers-OKD.crd.yaml Additional files +0/-3286

...

operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers-OKD.crd.yaml

11. operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers-TechPreviewNoUpgrade.crd.yaml Additional files +0/-3317

...

operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers-TechPreviewNoUpgrade.crd.yaml

qodo-code-review · 2026-04-08T16:01:39Z

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX Issues (0)

🐞\ ⚙ Maintainability (1)

1. Outdated experimental warning 🐞 ⚙

Description

The IngressControllerDynamicConfigurationManager feature is now enabled in Default/OKD, but the
corresponding API/CRD description for tuningOptions.configurationManagement still states the
"Dynamic" option is experimental and should not be enabled on production clusters, which will
mislead users and generated docs.

Code

features/features.go[665]

+								enable(inDefault(), inOKD(), inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).

Evidence
The PR changes the featuregate registration to enable IngressControllerDynamicConfigurationManager
in Default and OKD. However, both the Go type comment and the generated CRD schema description for
the configurationManagement field still include an explicit warning that "Dynamic" is experimental
and should not be used on production clusters, which conflicts with being enabled by default.
features/features.go[660-666]
operator/v1/types_ingress.go[2072-2100]
operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers.crd.yaml[2157-2184]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
IngressControllerDynamicConfigurationManager is now enabled in Default/OKD, but the API/CRD text for `tuningOptions.configurationManagement` still warns that the `Dynamic` option is experimental and should not be enabled on production clusters.

### Issue Context
With the featuregate promoted to Default, this warning becomes misleading in user-facing API docs and in the CRD schema descriptions.

### Fix Focus Areas
- features/features.go[660-666]
- operator/v1/types_ingress.go[2072-2100]
- operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers.crd.yaml[2157-2184]

### What to change
- Update the Go doc comment for `ConfigurationManagement` (and/or its surrounding comment block) to reflect the feature's new status.
- Regenerate/update the generated CRD manifest description so it matches the updated API comment (remove or rewrite the experimental/not-for-production warning).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

Miciah · 2026-04-08T16:12:38Z

@qodo-code-review,

Outdated experimental warning 🐞 ⚙

Description

The IngressControllerDynamicConfigurationManager feature is now enabled in Default/OKD, but the
corresponding API/CRD description for tuningOptions.configurationManagement still states the
"Dynamic" option is experimental and should not be enabled on production clusters, which will
mislead users and generated docs.

The featuregate will be enabled by default, but the feature will be off by default as it is an experimental feature. Enabling the featuregate just enables the cluster-admin to enable the feature by explicitly setting the new API field.

openshift-ci · 2026-04-08T16:46:25Z

@Miciah: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	`52fb33c`	link	true	`/test verify-feature-promotion`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2026

openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 31, 2026

Miciah force-pushed the NE-2569-promote-Dynamic-Configuration-Manager-to-Default branch from cd8658e to 52fb33c Compare March 31, 2026 21:06

Miciah changed the title ~~Promote Dynamic Configuration Manager to Default~~ NE-2569: Promote Dynamic Configuration Manager to Default Mar 31, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2026

openshift-ci bot assigned jcmoraisjr Apr 1, 2026

Miciah marked this pull request as ready for review April 8, 2026 16:01

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2026

openshift-ci bot requested review from JoelSpeed and everettraven April 8, 2026 16:05

Conversation

Miciah commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

coderabbitai bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Miciah commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Miciah commented Apr 1, 2026

Uh oh!

qodo-code-review bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcmoraisjr commented Apr 1, 2026

Uh oh!

bentito commented Apr 1, 2026

Uh oh!

gcs278 commented Apr 6, 2026

Uh oh!

gcs278 commented Apr 7, 2026

Uh oh!

gcs278 commented Apr 7, 2026

Uh oh!

Miciah commented Apr 8, 2026

Uh oh!

qodo-code-review bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qodo-code-review bot commented Apr 8, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-code-review bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

Miciah commented Apr 8, 2026

Uh oh!

openshift-ci bot commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented Mar 31, 2026 •

edited

Loading

openshift-ci-robot commented Mar 31, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 31, 2026 •

edited by openshift-ci bot

Loading

qodo-code-review bot commented Apr 1, 2026 •

edited

Loading

qodo-code-review bot commented Apr 8, 2026 •

edited

Loading

qodo-code-review bot commented Apr 8, 2026 •

edited

Loading