Repository navigation
Update data prepper parameters and diagram in the intro - #13393
kolchfa-aws wants to merge 5 commits into
Conversation
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). |
dlvenable
left a comment
There was a problem hiding this comment.
Thank you @kolchfa-aws for this great update to our documentation!
I have a few comments to improve.
| `sts_role_arn` | No | String | The AWS Security Token Service (AWS STS) role to assume for requests to Amazon Simple Queue Service (Amazon SQS) and Amazon Simple Storage Service (Amazon S3). Default is `null`, which will use the [standard SDK behavior for credentials](https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/credentials.html). | ||
| `msk` | No | JSON object | The [MSK](#msk) configuration settings. | ||
| `sts_header_overrides` | No | Map | A map of headers to add to the AWS STS `AssumeRole` request. You can specify up to 5 headers. | ||
| `role_session_name` | No | String | The role session name to use when authenticating to Amazon MSK using the role specified in `sts_role_arn`. Applies only when `aws_msk_iam` is set to `role`. |
There was a problem hiding this comment.
It appears that this is unused. Maybe remove it for now.
There was a problem hiding this comment.
Sure. This was used in 2.16 but I see it was removed for 2.17 so removing.
| `sts_role_arn` | No | String | The AWS STS role to assume for requests to Amazon Simple Queue Service (Amazon SQS) and Amazon Simple Storage Service (Amazon S3). Default is `null`, which will use the [standard SDK behavior for credentials](https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/credentials.html). | ||
| `msk` | No | JSON object | The [Amazon MSK](#msk) configuration settings. | ||
| `sts_header_overrides` | No | Map | A map of headers to add to the AWS STS `AssumeRole` request. You can specify up to 5 headers. | ||
| `role_session_name` | No | String | The role session name to use when authenticating to Amazon MSK using the role specified in `sts_role_arn`. Applies only when `aws_msk_iam` is set to `role`. |
| `path_prefix` | No | String | A path prefix that the sink adds to the path of every request sent to OpenSearch, for example, `/opensearch`. Use this option when OpenSearch is accessible under a subpath, such as behind a reverse proxy. | ||
| `index` | Conditionally | String | The name of the export index. Only required when the `index_type` is `custom`. The index can be a plain string, such as `my-index-name`, contain [Java date-time patterns](https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html), such as `my-index-%{yyyy.MM.dd}` or `my-%{yyyy-MM-dd-HH}-index`, be formatted using field values, such as `my-index-${/my_field}`, or use [Data Prepper expressions]({{site.url}}{{site.baseurl}}/data-prepper/pipelines/expression-syntax/), such as `my-index-${getMetadata(\"my_metadata_field\"}`. All formatting options can be combined to provide flexibility when creating static, dynamic, and rolling indexes. | ||
| `index_type` | No | String | Specifies the type of data the sink plugin handles. Valid values include `custom`, `trace-analytics-raw`, `trace-analytics-plain-raw`, `trace-analytics-service-map`, `log-analytics`, `log-analytics-plain`, `metric-analytics`, `metric-analytics-plain`, and `management-disabled`. <br><br>To produce Amazon Security Lake–compliant data from the `otel_logs_source` with `output_format: otel`, set `index_type` to `log-analytics-plain`. <br>For `otel_metrics_source` with `output_format: otel`, set `index_type` to `metric-analytics-plain`. <br>For `otel_trace_source` with `output_format: otel`, set `index_type` to `trace-analytics-plain-raw`. <br><br>Default is `custom`. | ||
| `index_type` | No | String | Specifies the type of data the sink plugin handles. Valid values include `custom`, `trace-analytics-raw`, `trace-analytics-plain-raw`, `trace-analytics-service-map`, `otel-v2-apm-service-map`, `log-analytics`, `log-analytics-plain`, `metric-analytics`, `metric-analytics-plain`, `tsdb`, and `management_disabled`. <br><br>To produce Amazon Security Lake–compliant data from the `otel_logs_source` with `output_format: otel`, set `index_type` to `log-analytics-plain`. <br>For `otel_metrics_source` with `output_format: otel`, set `index_type` to `metric-analytics-plain`. <br>For `otel_trace_source` with `output_format: otel`, set `index_type` to `trace-analytics-plain-raw`. <br><br>Default is `custom`. |
There was a problem hiding this comment.
We recently added: trace-analytics-plain-raw-v2 and it will release in 2.17. Please include this here as well.
There was a problem hiding this comment.
Sure, adding these. Will wait until DP 2.17 is out to merge this PR.
| The following example configures response streaming: | ||
|
|
||
| ```yaml | ||
| processors: |
There was a problem hiding this comment.
This should be processor:. Singular, not plural.
| `paths` | Conditionally | List | A list of absolute file paths or glob patterns that specify the files to read, for example, `/var/log/app/*.log` or `/var/log/**/*.log`. Either `path` or `paths` is required. | ||
| `exclude_paths` | No | List | A list of absolute file paths or glob patterns that specify files to skip among the files matched by `paths`. | ||
| `format` | No | String | Specifies how to interpret the file content. Valid values are `json` and `plain`. Use `json` when your file has one JSON object per line or a JSON array. Use `plain` for raw text lines. Applies only when `path` is used without `paths`, `exclude_paths`, `codec`, or `tail`. Default is `plain`. | ||
| `record_type` | No | String | The type of output record produced by the source. Valid values are `event` and `string`. Use `event` to produce structured events expected by downstream processors and the OpenSearch sink. Applies only when `path` is used without `paths`, `exclude_paths`, `codec`, or `tail`. Default is `string`. |
There was a problem hiding this comment.
When a codec is configured, the customer must set record_type to event. We have an assertion on this currently.
| The source reads files in one of the following ways, depending on its configuration: | ||
|
|
||
| - If you specify `path` and none of the `paths`, `exclude_paths`, `codec`, or `tail` settings, the source reads the file once, line by line, and creates events according to the `format` and `record_type` settings. | ||
| - If you specify `paths`, `exclude_paths`, `codec`, or `tail`, the source ignores the `format` and `record_type` settings. It parses each file using the configured `codec` or, if no `codec` is configured, creates one event for each line. For the structure of these events, see [Event structure](#event-structure). |
There was a problem hiding this comment.
When a codec is configured, the customer must set record_type to event. We have an assertion on this currently. Please reword to clarify that this value must be set to event.
| The source reads files in one of the following ways, depending on its configuration: | ||
|
|
||
| - If you specify `path` and none of the `paths`, `exclude_paths`, `codec`, or `tail` settings, the source reads the file once, line by line, and creates events according to the `format` and `record_type` settings. | ||
| - If you specify `paths`, `exclude_paths`, `codec`, or `tail`, the source ignores the `format` and `record_type` settings. It parses each file using the configured `codec` or, if no `codec` is configured, creates one event for each line. For the structure of these events, see [Event structure](#event-structure). |
There was a problem hiding this comment.
It may be good to add that the recommended configuration is to use record_type: event and provide a codec:. The format and record_type: string are legacy configurations.
| `fetch_min_bytes` | No | String | The minimum amount of data the server returns during a fetch request through Kafka's `fetch.min.bytes` setting. Default is `2kb`. | ||
| `retry_backoff` | No | Duration | The amount of time to wait before attempting to retry a failed request to a given topic partition. Default is `10s`. | ||
| `reconnect_backoff` | No | Duration | The amount of time to wait before attempting to reconnect to a broker through Kafka's `reconnect.backoff.ms` setting. Default is `10s`. | ||
| `max_poll_interval` | No | Duration | The maximum delay between invocations of a `poll()` when using group management through Kafka's `max.poll.interval.ms` option. Default is `300s`. |
There was a problem hiding this comment.
We have recently added:
bounded_buffer_sizebounded_batch_size
It may be good to include these. They will release in 2.17.
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
|
Thank you for reviewing, @dlvenable! I addressed your comments. |
|
This will be a great improvement to the public docs! |
|
Waiting for DP 2.17 to merge |
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
This PR brings parameter tables in data prepper up to date with the current release. It adds more example configuration and udpates the trace analytics diagram so it follows the intro sentence.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.