Skip to content

[Backport 2.19] Guard eclipse() to spotless tasks and keep P2 mirror on pinned version (common-utils) - #1008

Merged
gaiksaya merged 3 commits into
opensearch-project:2.19from
peterzhuamazon:backport/backport-1004-to-2.19
Sep 11, 2026
Merged

[Backport 2.19] Guard eclipse() to spotless tasks and keep P2 mirror on pinned version (common-utils)#1008
gaiksaya merged 3 commits into
opensearch-project:2.19from
peterzhuamazon:backport/backport-1004-to-2.19

Conversation

@peterzhuamazon

@peterzhuamazon peterzhuamazon commented Sep 9, 2026

Copy link
Copy Markdown
Member

Backport 846658a from #1004.

…n (common-utils)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit fc46755.

Hard block: Issues at High severity or above will block this PR from merging.

PathLineSeverityDescription
build.gradle28highDependency version change: com.diffplug.spotless:spotless-plugin-gradle bumped from 6.22.0 to 8.10.1. Per mandatory supply-chain rule, all dependency version changes must be flagged regardless of apparent legitimacy. Maintainers should verify the artifact hash and changelog before merging.
build.gradle139mediumEclipse JDT formatter is now explicitly pinned to version 4.27 and resolved through the P2 mirror at https://ci.opensearch.org/ (substituting https://download.eclipse.org/). The mirror was present before this diff, but the new explicit version pin anchors artifact resolution to a specific build served by a third-party CI host rather than the canonical Eclipse P2 site. Maintainers should confirm that ci.opensearch.org is a controlled, trusted mirror and that the 4.27 artifact it serves matches the canonical Eclipse release.

The table above displays the top 10 most important findings.

Total: 2 | Critical: 0 | High: 1 | Medium: 1 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@peterzhuamazon peterzhuamazon added the skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. label Sep 10, 2026
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit 479d839)

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

…orkflows (common-utils)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 479d839

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 479d839

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (2.19@1592e99). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             2.19    #1008   +/-   ##
=======================================
  Coverage        ?   70.56%           
  Complexity      ?     1032           
=======================================
  Files           ?      162           
  Lines           ?     7135           
  Branches        ?      810           
=======================================
  Hits            ?     5035           
  Misses          ?     1766           
  Partials        ?      334           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaiksaya
gaiksaya merged commit 6d75b38 into opensearch-project:2.19 Sep 11, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants