Skip to content

Guard eclipse() to spotless tasks and keep P2 mirror on pinned version (common-utils) - #1004

Merged
cwperks merged 1 commit into
opensearch-project:mainfrom
peterzhuamazon:eclipse-pin-separation
Sep 6, 2026
Merged

Guard eclipse() to spotless tasks and keep P2 mirror on pinned version (common-utils)#1004
cwperks merged 1 commit into
opensearch-project:mainfrom
peterzhuamazon:eclipse-pin-separation

Conversation

@peterzhuamazon

Copy link
Copy Markdown
Member

Description

Guard eclipse() to spotless tasks and keep P2 mirror on pinned version.

Issues Resolved

opensearch-project/opensearch-build#6421

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…n (common-utils)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon

Copy link
Copy Markdown
Member Author

expected version pin

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit c7f42e8.

Hard block: Issues at High severity or above will block this PR from merging.

PathLineSeverityDescription
build.gradle35highBuild plugin version bumped from com.diffplug.spotless 6.25.0 to 8.10.1 — a major version jump (6→8). Per mandatory supply chain rule, all build plugin version changes must be flagged for maintainer verification regardless of apparent legitimacy. Verify the artifact at the Gradle Plugin Portal matches the expected publisher and SHA before merging.
build.gradle141highEclipse JDT formatter dependency explicitly pinned to version '4.29' where previously no version was specified (resolved implicitly). Per mandatory supply chain rule, any new explicit dependency version specification must be flagged. Confirm that eclipse('4.29') resolves to the intended artifact from Maven Central through the ci.opensearch.org mirror and that the mirror itself has not been compromised or substituted.

The table above displays the top 10 most important findings.

Total: 2 | Critical: 0 | High: 2 | Medium: 0 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.55%. Comparing base (3a69aab) to head (c7f42e8).
⚠️ Report is 119 commits behind head on main.

❌ Your project check has failed because the head coverage (70.55%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1004      +/-   ##
============================================
- Coverage     73.97%   70.55%   -3.42%     
- Complexity      916     1149     +233     
============================================
  Files           135      175      +40     
  Lines          6102     7971    +1869     
  Branches        753      956     +203     
============================================
+ Hits           4514     5624    +1110     
- Misses         1253     1948     +695     
- Partials        335      399      +64     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterzhuamazon peterzhuamazon added the skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. label Sep 3, 2026
@cwperks
cwperks merged commit 846658a into opensearch-project:main Sep 6, 2026
31 of 33 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Sep 6, 2026
@opensearch-ci-bot

Copy link
Copy Markdown
Contributor

The backport to 2.19 failed. Please backport manually. See failed workflow run: https://github.com/opensearch-project/common-utils/actions/runs/34004602288

cwperks pushed a commit that referenced this pull request Sep 6, 2026
…n (common-utils) (#1004) (#1006)

(cherry picked from commit 846658a)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.19 backport 3.8 Backport to 3.8 branch enhancement New feature or request release skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. v3.9.0 Issues targeting release v3.9.0

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants