Rename resource sharing feature flag to the non-experimental key - #1778
Merged
kaituo merged 1 commit intoSep 16, 2026
Conversation
Resource sharing graduates out of experimental in opensearch-project/security#6348, which drops the experimental. segment from the feature-flag settings with no deprecated fallback: plugins.security.experimental.resource_sharing.enabled -> plugins.security.resource_sharing.enabled plugins.security.experimental.resource_sharing.protected_types -> plugins.security.resource_sharing.protected_types Updates the integTest cluster settings to the new keys. Only the setting strings change. The ConfigConstants constant names (OPENSEARCH_RESOURCE_SHARING_ENABLED, OPENSEARCH_RESOURCE_SHARING_PROTECTED_TYPES) are unchanged, so no Java/Kotlin references are affected. The gradle -Dresource_sharing.enabled system property that gates the CI matrix is a separate toggle and is left as is. Verified no occurrence of the old key remains anywhere in the repo. Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
graduate/resource-sharing-non-experimental
branch
from
September 15, 2026 21:14
993f106 to
614e59f
Compare
Contributor
PR Reviewer Guide 🔍(Review updated until commit 614e59f)Here are some key observations to aid the review process:
|
Contributor
|
Persistent review updated to latest commit 614e59f |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
=========================================
Coverage 81.06% 81.06%
+ Complexity 6681 6677 -4
=========================================
Files 556 556
Lines 27267 27267
Branches 2898 2898
=========================================
Hits 22105 22105
Misses 3694 3694
Partials 1468 1468
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
DarshitChanpura
marked this pull request as ready for review
September 15, 2026 22:19
DarshitChanpura
requested review from
VijayanB,
amitgalitz,
dbwiddis,
jackiehanyang,
jmazanec15,
jngz-es,
joshpalis,
kaituo,
ohltyler,
owaiskazi19,
saratvemulapalli,
sean-zheng-amazon,
vamshin and
ylwu-amzn
as code owners
September 15, 2026 22:19
Contributor
|
Persistent review updated to latest commit 614e59f |
kaituo
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resource sharing graduates out of experimental in opensearch-project/security#6348, which drops the
experimental.segment from the feature-flag settings with no deprecated fallback:plugins.security.experimental.resource_sharing.enabledplugins.security.resource_sharing.enabledplugins.security.experimental.resource_sharing.protected_typesplugins.security.resource_sharing.protected_typesUpdates the integTest cluster settings in
build.gradleto the new keys.Only the setting strings change. The
ConfigConstantsconstant names (OPENSEARCH_RESOURCE_SHARING_ENABLED,OPENSEARCH_RESOURCE_SHARING_PROTECTED_TYPES) are unchanged, so no Java/Kotlin references are affected. The gradle-Dresource_sharing.enabledsystem property that gates the resource-sharing CI matrix is a separate toggle and is left as is.Because the rename has no fallback, the security integTest jobs here will fail to start a node (
unknown setting [plugins.security.resource_sharing.enabled]) until a new 3.9 security snapshot publishes. Security PR 6348 is merged, so that republish is the only remaining gate; this needs to land in 3.9 with it.Related Issues
Companion to opensearch-project/security#6348. Related to opensearch-project/security#4500
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.