Remove obsolete os packaging tests - #22879
Conversation
PR Reviewer Guide 🔍(Review updated until commit 48ed61a)Here are some key observations to aid the review process:
|
|
Hey, @imdhemy, it looks like since #22719 made changes to a couple of the Can you please resolve the conflict from your end and push the updated commit? I've merged @andrross's fix to the change detection logic. |
14f7f3e to
9b13792
Compare
|
Persistent review updated to latest commit 9b13792 |
|
@msfroh I've rebased the branch & resolved the conflicts. |
|
❌ Gradle check result for 9b13792: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 9b13792: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
9b13792 to
d98d94b
Compare
|
Persistent review updated to latest commit d98d94b |
d98d94b to
97c0b49
Compare
|
Persistent review updated to latest commit 97c0b49 |
|
❌ Gradle check result for 97c0b49: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 97c0b49: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Dhemy <imdhemy@gmail.com>
Signed-off-by: Dhemy <imdhemy@gmail.com>
97c0b49 to
762b153
Compare
|
Persistent review updated to latest commit 762b153 |
|
❌ Gradle check result for 762b153: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Hmm... the build failure is related to a failure on the 2.19 branch to download the Java formatter config, but AFAIK, @peterzhuamazon fixed that in #22793. @peterzhuamazon -- do you have any idea why your fix isn't helping here? It looks like it should be fine from what I can see. |
@msfroh That spotless backport on 2.19 should (might?) fix this... |
|
Persistent review updated to latest commit 0bc66ae |
|
❌ Gradle check result for 0bc66ae: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Persistent review updated to latest commit 48ed61a |
|
❌ Gradle check result for 48ed61a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
qa/ospackaging tests and related configuration.Related Issues
Resolves #22870
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.