Skip to content

Remove obsolete os packaging tests - #22879

Open
imdhemy wants to merge 4 commits into
opensearch-project:mainfrom
imdhemy:remove-obsolete-os-packaging-tests
Open

Remove obsolete os packaging tests#22879
imdhemy wants to merge 4 commits into
opensearch-project:mainfrom
imdhemy:remove-obsolete-os-packaging-tests

Conversation

@imdhemy

@imdhemy imdhemy commented Aug 29, 2026

Copy link
Copy Markdown

Description

  • Remove the obsolete qa/os packaging tests and related configuration.
  • Remove the unused distro-test and Vagrant build tooling.

Related Issues

Resolves #22870

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@imdhemy
imdhemy requested review from a team, jed326 and peternied as code owners August 29, 2026 14:47
@github-actions github-actions Bot added Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request labels Aug 29, 2026
@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit 48ed61a)

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@andrross

Copy link
Copy Markdown
Member

Thanks @imdhemy! Looks like you exposed a bug in our CI workflow that doesn't consider a deleted file as a change. I've got a fix here: #22881 Once that is merged we can rebase this once and ensure the gradle check workflow runs.

@msfroh

msfroh commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Hey, @imdhemy, it looks like since #22719 made changes to a couple of the build.gradle files that you deleted. Unfortunately, GitHub doesn't let me resolve the conflict (by deleting the files) through the UI.

Can you please resolve the conflict from your end and push the updated commit? I've merged @andrross's fix to the change detection logic.

@imdhemy
imdhemy force-pushed the remove-obsolete-os-packaging-tests branch from 14f7f3e to 9b13792 Compare August 31, 2026 20:00
@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 9b13792

@imdhemy

imdhemy commented Aug 31, 2026

Copy link
Copy Markdown
Author

@msfroh I've rebased the branch & resolved the conflicts.

@github-actions

Copy link
Copy Markdown
Contributor

❌ Gradle check result for 9b13792: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions

Copy link
Copy Markdown
Contributor

❌ Gradle check result for 9b13792: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@imdhemy
imdhemy force-pushed the remove-obsolete-os-packaging-tests branch from 9b13792 to d98d94b Compare September 1, 2026 11:45
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit d98d94b

@imdhemy
imdhemy force-pushed the remove-obsolete-os-packaging-tests branch from d98d94b to 97c0b49 Compare September 1, 2026 11:50
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 97c0b49

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

❌ Gradle check result for 97c0b49: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

❌ Gradle check result for 97c0b49: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Dhemy <imdhemy@gmail.com>
Signed-off-by: Dhemy <imdhemy@gmail.com>
@msfroh
msfroh force-pushed the remove-obsolete-os-packaging-tests branch from 97c0b49 to 762b153 Compare September 1, 2026 18:07
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 762b153

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

❌ Gradle check result for 762b153: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@msfroh

msfroh commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Hmm... the build failure is related to a failure on the 2.19 branch to download the Java formatter config, but AFAIK, @peterzhuamazon fixed that in #22793.

@peterzhuamazon -- do you have any idea why your fix isn't helping here? It looks like it should be fine from what I can see.

@andrross

andrross commented Sep 1, 2026

Copy link
Copy Markdown
Member

Hmm... the build failure is related to a failure on the 2.19 branch to download the Java formatter config, but AFAIK,

@msfroh That spotless backport on 2.19 should (might?) fix this...

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 0bc66ae

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

❌ Gradle check result for 0bc66ae: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 48ed61a

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

❌ Gradle check result for 48ed61a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] rm -rf qa/os

3 participants