Skip to content

Rename internal functions - #94

Merged
sadrasabouri merged 10 commits into
devfrom
refactor
Aug 12, 2026
Merged

sadrasabouri merged 10 commits into
devfrom
refactor

Conversation

@sepandhaghighi

@sepandhaghighi sepandhaghighi commented Jul 31, 2026 •

Copy link
Copy Markdown
Member

Reference Issues/PRs

#93

What does this implement/fix? Explain your changes.

Rename internal functions from __ prefix to _ prefix

Any other comments?

Local tests on OSs

  • macOS
    • Sonoma
  • Windows
    • Windows 11
  • Linux
    • Ubuntu 22.04

@sepandhaghighi sepandhaghighi added this to the nava v0.9 milestone Jul 31, 2026
@sepandhaghighi sepandhaghighi self-assigned this Jul 31, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 67 complexity · 0 duplication

Metric Results
Complexity 67
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.37%. Comparing base (2d121c1) to head (5c014f2).

Files with missing lines Patch % Lines
nava/functions.py 95.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #94   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files           5        5           
  Lines         301      301           
  Branches       39       39           
=======================================
  Hits          269      269           
  Misses         28       28           
  Partials        4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi
sepandhaghighi marked this pull request as ready for review August 10, 2026 10:49

@sadrasabouri sadrasabouri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested it in MacOS

@sadrasabouri
sadrasabouri merged commit 6b9f4a3 into dev Aug 12, 2026
35 checks passed
@sadrasabouri
sadrasabouri deleted the refactor branch August 12, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants