Skip to content

Implement timer's (set interval & pause/resume)#1087

Open
NoPressF wants to merge 1 commit into
openmultiplayer:masterfrom
NoPressF:timer-features
Open

Implement timer's (set interval & pause/resume)#1087
NoPressF wants to merge 1 commit into
openmultiplayer:masterfrom
NoPressF:timer-features

Conversation

@NoPressF

Copy link
Copy Markdown
Contributor

No description provided.

@AmyrAhmady

Copy link
Copy Markdown
Member

You must create a pull request in https://github.com/openmultiplayer/open.mp-sdk for your fork of SDK repository, because right now this PR is pointing to a commit hash that doesn't exist in our own SDK repository, it's only in yours.

Also you shouldn't add functions randomly in the middle of the virtual table (in ITimer in this example), new ones must be added to the end, after last virtual function. So this way we're not breaking ABI compatibility even more.

@AmyrAhmady AmyrAhmady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explained in comments

@NoPressF

Copy link
Copy Markdown
Contributor Author

@NoPressF

Copy link
Copy Markdown
Contributor Author

@AmyrAhmady what about that?

@Zorono

Zorono commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

@NoPressF please adopt my changes in your PR #1103 (i don't have enough time to refactor my changes again )

@NexiusTailer

Copy link
Copy Markdown
Contributor

@NoPressF please adopt my changes in your PR #1103 (i don't have enough time to refactor my changes again )

You were clearly requested changes in your fork which you didn't complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants