Add clone3-workaround wrapper to support Docker < 20.10.10#458
Open
romainreignier wants to merge 1 commit intoopenmaptiles:masterfrom
Open
Add clone3-workaround wrapper to support Docker < 20.10.10#458romainreignier wants to merge 1 commit intoopenmaptiles:masterfrom
romainreignier wants to merge 1 commit intoopenmaptiles:masterfrom
Conversation
See openmaptiles/openmaptiles#1719 openmaptiles claims to support Docker >= 1.12.3 but GLIBC >= 2.34 we need Docker >= 20.10.10 and openmaptiles/openmaptiles-tools currently uses Debian 12 as base OS that uses GLBC 2.36.
That was released 2021-10-25. Would a better solution for this not be to just bump the documented requirement? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See openmaptiles/openmaptiles#1719
openmaptiles claims to support Docker >= 1.12.3 but GLIBC >= 2.34 we need Docker >= 20.10.10 and openmaptiles/openmaptiles-tools currently uses Debian 12 as base OS that uses GLBC 2.36.
The wrapper is added as an entrypoint and always used.
We could also use it optionally from the openmaptiles/openmaptiles Makefile based on the Docker version detected?