Fix toolchain support for non-java executables#154
Open
anthonyvdotbe wants to merge 1 commit intoopenjfx:masterfrom
Open
Fix toolchain support for non-java executables#154anthonyvdotbe wants to merge 1 commit intoopenjfx:masterfrom
anthonyvdotbe wants to merge 1 commit intoopenjfx:masterfrom
Conversation
Signed-off-by: Anthony Vanelverdinghe <dev@anthonyv.be>
Contributor
Author
|
@abhinayagarwal @jperedadnr will you please review? (mentioning you since you reviewed the original PR as well) |
|
This should probably be added to other places where |
Contributor
Author
|
@alerosmile the sole goal of this PR is to fix the regression introduced in #118 If you believe toolchain support is incomplete or should be improved, please file a new issue and/or PR instead. |
OmSarabeSolutions
approved these changes
Sep 28, 2024
Contributor
Author
|
@jperedadnr @abhinayagarwal @johanvos would you mind merging and releasing a new version to Maven Central please? This is a trivial fix that has been confirmed to work by 2 different people. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#118 introduced toolchain support. However, due to the hard-coded
"java", this doesn't work for non-java executables such as jlink (i.e. #148)Fixes #148