8379694: [lworld] Add value class test coverage to java.util.Arrays by bwhuang-us · Pull Request #2314 · openjdk/valhalla

bwhuang-us · 2026-04-09T17:40:02Z

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Tests Updated

TEST.groups
Add java/util/Arrays to valhalla_adopted, bringing the Arrays test directory into the Valhalla-adopted test group.

AsList.java
Add value-oriented object-array datasets: an @AsValueClass record, boxed Integer, LocalDate, and Optional. This extends the existing iterator contract test to ensure Arrays.asList() behaves the same for value-capable elements, including assertSame on iteration.

ArrayObjectMethods.java
Add an @AsValueClass record and extend the random object/nested-object generators so value objects and value-object arrays participate in the existing toString, deepToString, hashCode, deepHashCode, and deepEquals coverage. This broadens mixed-content object-array coverage rather than adding a separate value-only test path.

ArraysEqCmpTest.java
Add an @AsValueClass Point type and a corresponding ArrayType so the existing Arrays.equals, Arrays.compare, and Arrays.mismatch matrix now runs on value-object arrays too. The object-array same-element tests were also generalized to use the ArrayType abstraction instead of assuming Integer[].

Big.java
Add a large-array Point[] path using an @AsValueClass record. This extends the existing huge-array binarySearch and range-sort coverage to value-object arrays.

CopyMethods.java
Add Point, LocalDate, and Optional to the reflective copy/copyOfRange test matrix, plus the coercion and cloner wiring needed for those types. This extends the existing generic copy-method framework to value-capable reference types.

Correct.java
Add an @AsValueClass Point type plus default-sort and comparator-sort subrange tests for Point[], using the existing “compare against reference sort” approach.

Fill.java
Add an @AsValueClass array target and verify existing exception behavior when filling it with the wrong type or with an out-of-bounds range.

HashCode.java
Add an @AsValueClass Point test that checks Arrays.hashCode(Point[]) is equal for equal value-object arrays and stable across repeated calls.

SetAllTest.java
Add Point[] coverage for Arrays.setAll and Arrays.parallelSetAll, including normal generation cases and the existing null-argument exception checks.

Sorting.java
Add an @AsValueClass Point sort path to the main sorting test suite. This extends the existing object-sort coverage to value objects for both natural ordering and comparator ordering.

StreamAndSpliterator.java
Extend the existing null-array and bad-range exception tests to additional reference-array types: Integer[], Long[], Optional[], and LocalDate[]. This broadens object-array coverage for Arrays.stream, Arrays.spliterator, and Spliterators.spliterator.

largeMemory/ParallelPrefix.java
Add an @AsValueClass VInt type and extend the existing parallelPrefix framework to cover value-object arrays, including normal prefix computation plus NPE/IAE/AIOOBE checks.

Tests With No Change

FloatDoubleOrder.java
No change -- primitive-only float/double ordering test.

SortingIntBenchmarkTestJMH.java, SortingLongBenchmarkTestJMH.java
No change -- primitive-array JMH benchmarks.

SortingNearlySortedPrimitive.java
No change -- primitive-only nearly-sorted coverage.

TimSortStackSize.java, TimSortStackSize2.java
No change -- TimSort stack-shape regression tests over existing Integer[] inputs.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

JDK-8379694: [lworld] Add value class test coverage to java.util.Arrays (Task - P4)

Reviewers

Chen Liang (@liach - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2314/head:pull/2314
$ git checkout pull/2314

Update a local copy of the PR:
$ git checkout pull/2314
$ git pull https://git.openjdk.org/valhalla.git pull/2314/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2314

View PR using the GUI difftool:
$ git pr show -t 2314

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2314.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-04-09T17:41:49Z

👋 Welcome back bhuang! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-04-09T18:07:21Z

@bwhuang-us This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379694: [lworld] Add value class test coverage to java.util.Arrays

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the lworld branch:

8b5c1ad: 8381996: [lworld] JNIHandles::is_same_object makes an unsafe Java upcall
9b8b3eb: 8382071: [lworld] Print more information at "must constrain OSR typestate" assert
6ae315c: 8381574: [lworld] Merge of JDK-8365501 broke the scalarized calling convention for abstract methods
... and 15 more: https://git.openjdk.org/valhalla/compare/de4e3f5e0d297cf13f00af16dd91a035f0755af0...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@liach) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

liach · 2026-04-10T16:05:19Z

test/jdk/java/util/Arrays/Correct.java

+        }
+    }
+
    static void stupidSort(Integer[] a1, int from, int to) {


I recommend changing the static types of Integer[] to Comparable[] instead of introducing identical copies of stupid sort. Same for the comparator version, but the comparator version can take Object[]

liach · 2026-04-10T16:08:25Z

test/jdk/java/util/Arrays/HashCode.java

+            throw new RuntimeException("testValueClassArrayHashCode: expected equal hash codes " +
+                "for equal value class arrays, got " + hashA + " and " + hashB);
+        }
+        // Consistency with repeated calls (no identity hash interference)


There's nothing relevant to identity hash here, dead comment?

This comment is for the repeated call on hashCode() below. It doesn't specifically demonstrate anything about identity hash behavior. I will reword it to "Repeated calls should produce the same array hash code"

liach · 2026-04-10T16:08:26Z

test/jdk/java/util/Arrays/HashCode.java

 public class HashCode {
+
+    @AsValueClass
+    record Point(int x, int y) {}


You might consider make its hashCode just return Objects.identityHashCode if preview is enabled for better coverage?
Like:

if (Point.class.isValue()) { return Objects.identityHashCode(this); }

I will change the Point record to a class, as value classes fall back to Object.hashCode() which is computed via System.identityHashCode(), per JEP 401.

liach · 2026-04-10T16:09:22Z

test/jdk/java/util/Arrays/SetAllTest.java

+    public void testSetAllPoint(String name, int size, IntFunction<Point> generator, Point[] expected) {
+        Point[] result = new Point[size];
+        Arrays.setAll(result, generator);
+        Assertions.assertArrayEquals(expected, result, "setAll(Point[], IntFunction<Point>) case " + name + " failed.");


The message is redundant because junit already does it but since this is a copycat guess it's fine.

Are you suggesting to completely remove the assertion message or keep the "setAll" and "parallelSetAll" cases to indicate the operations?

You can keep setAll/parallelSetAll. Even though they can be deduced from line numbers, that is not quite straightforward.

JUnit when reporting the failure already includes the name argument passed for ParameterizedTest, or you can make the @ParameterizedTest(name = "{0}") so it substitutes the name arg in its parameterized name.

test/jdk/java/util/Arrays/SetAllTest.java

mlbridge · 2026-04-10T21:49:56Z

Webrevs

01: Full - Incremental (2795a743)
00: Full (9c98a0c4)

liach

Lgtm, the error message beautification is trivial.

JDK-8379694 Add value class test coverage to java.util.Arrays

9c98a0c

openjdk bot changed the title ~~JDK-8379694 Add value class test coverage to java.util.Arrays~~ 8379694: Add value class test coverage to java.util.Arrays Apr 9, 2026

bwhuang-us changed the title ~~8379694: Add value class test coverage to java.util.Arrays~~ JDK-8379694 Add value class test coverage to java.util.Arrays Apr 10, 2026

openjdk bot changed the title ~~JDK-8379694 Add value class test coverage to java.util.Arrays~~ 8379694: Add value class test coverage to java.util.Arrays Apr 10, 2026

bwhuang-us changed the title ~~8379694: Add value class test coverage to java.util.Arrays~~ 8379694: [lworld] Add value class test coverage to java.util.Arrays Apr 10, 2026

liach reviewed Apr 10, 2026

View reviewed changes

openjdk bot added the rfr Pull request is ready for review label Apr 10, 2026

Implemented review comments

2795a74

liach approved these changes Apr 14, 2026

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8379694: [lworld] Add value class test coverage to java.util.Arrays#2314

8379694: [lworld] Add value class test coverage to java.util.Arrays#2314
bwhuang-us wants to merge 2 commits intoopenjdk:lworldfrom
bwhuang-us:libs-arrays

bwhuang-us commented Apr 9, 2026 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Apr 9, 2026

Uh oh!

openjdk bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

liach Apr 10, 2026

Uh oh!

liach Apr 10, 2026

Uh oh!

bwhuang-us Apr 13, 2026

Uh oh!

liach Apr 10, 2026

Uh oh!

bwhuang-us Apr 13, 2026

Uh oh!

liach Apr 10, 2026

Uh oh!

bwhuang-us Apr 13, 2026

Uh oh!

liach Apr 14, 2026

Uh oh!

Uh oh!

mlbridge bot commented Apr 10, 2026 •

edited

Loading

Uh oh!

liach left a comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

bwhuang-us commented Apr 9, 2026 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 9, 2026

Uh oh!

openjdk bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mlbridge bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

liach left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

bwhuang-us commented Apr 9, 2026 •

edited by openjdk bot

Loading

openjdk bot commented Apr 9, 2026 •

edited

Loading

mlbridge bot commented Apr 10, 2026 •

edited

Loading