8379614: [lworld] runtime/valhalla/inlinetypes/InlineTypeDensity.java fails with UCOH

[caspernorrbin]

Hi everyone,

The test InlineTypeDensity.java builds on incorrect assumptions that a null restricted non-atomic value class is identical to a primitive type, which is not necessarily the case. For example, the first element of an array has to be aligned to 64 bits, while in a primitive type it does not. With COH enabled, this causes the test to fail, as the value class becomes bigger than its primitive equivalent.

I have reworked this test to instead check that everything is flattened as expected, and that the alignment of the first element is correctly 64 bits. With these changes, I have also removed vm.flagless which makes us able to run this test in more configurations.

Testing:

• Tiers 1-3
• Manual runs of the test with different flag combinations.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8379614: [lworld] runtime/valhalla/inlinetypes/InlineTypeDensity.java fails with UCOH (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Committer) ⚠️ Review applies to 4447566e
• Frederic Parain (@fparain - Committer) ⚠️ Review applies to 4447566e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2295/head:pull/2295
$ git checkout pull/2295

Update a local copy of the PR:
$ git checkout pull/2295
$ git pull https://git.openjdk.org/valhalla.git pull/2295/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2295

View PR using the GUI difftool:
$ git pr show -t 2295

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2295.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cnorrbin! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@caspernorrbin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379614: [lworld] runtime/valhalla/inlinetypes/InlineTypeDensity.java fails with UCOH

Reviewed-by: stefank, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 139 new commits pushed to the lworld branch:

• 8b5c1ad: 8381996: [lworld] JNIHandles::is_same_object makes an unsafe Java upcall
• 9b8b3eb: 8382071: [lworld] Print more information at "must constrain OSR typestate" assert
• 6ae315c: 8381574: [lworld] Merge of JDK-8365501 broke the scalarized calling convention for abstract methods
• ... and 136 more: https://git.openjdk.org/valhalla/compare/c089179bf47d4d6474413e4da25de121036b67f8...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (ace6c151)
• 00: Full (4447566e)

[stefank]

Looks good to me. The test functions could stay non-public, I think.

[fparain]

LGTM.
Thank you for fixing this test.

[caspernorrbin]

/template append

[openjdk]

@caspernorrbin The pull request template has been appended to the pull request body

[caspernorrbin]

Thank you both for reviewing

/integrate

[openjdk]

@caspernorrbin
Your change (at version ace6c15) is now ready to be sponsored by a Committer.

[fparain]

/sponsor

[openjdk]

Going to push as commit c8bdf17.
Since your change was applied there have been 139 commits pushed to the lworld branch:

• 8b5c1ad: 8381996: [lworld] JNIHandles::is_same_object makes an unsafe Java upcall
• 9b8b3eb: 8382071: [lworld] Print more information at "must constrain OSR typestate" assert
• 6ae315c: 8381574: [lworld] Merge of JDK-8365501 broke the scalarized calling convention for abstract methods
• ... and 136 more: https://git.openjdk.org/valhalla/compare/c089179bf47d4d6474413e4da25de121036b67f8...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@fparain @caspernorrbin Pushed as commit c8bdf17.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.