Repository navigation
Update Java base images - #321
Conversation
This comment has been minimized.
This comment has been minimized.
2be04f8 to
e8f5fc3
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
e8f5fc3 to
8d83f73
Compare
This comment has been minimized.
This comment has been minimized.
JCenter is deprecated and read-only. Use Maven Central for dependency resolution in the Java 11, Java 11 Vert.x, and Java 17 templates. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)9/10. The changes are focused and low risk; no blocking correctness, runtime, or documentation issues were identified in the scoped diff. Summary per fileSummary per file
Overall AssessmentThe PR addresses the removed Docker Hub OpenJDK image tags with a narrow migration to maintained Eclipse Temurin Noble images, while preserving the intended JRE runtime stages. The added Detailed ReviewDetailed ReviewNo blocking findings. The image changes in The repository changes from The README updates match the changed Dockerfile Gradle versions and correct previously stale template and handler-path text. The changed documentation does not introduce a rendering issue in the inspected Markdown. AI agent details. |
Description
Update the
java11,java11-vert-x, andjava17templates from the removed OpenJDK 11 and 17 Docker Hub tags toeclipse-temurin:*-noble, following maintainer feedback. The runtime stages continue to use JRE images rather than JDK images.Add
RUN chown -R app /home/appto thejava11andjava17templates so the non-rootappuser can extract the function distribution on Noble.Correct outdated Java and Gradle versions, handler paths, and dependency information in the three template READMEs.
Replace the deprecated JCenter repository with Maven Central throughout the Java templates.
Motivation and Context
The OpenJDK 11 and 17 tags used by the Java templates have been removed from Docker Hub, causing builds to fail while resolving the base images. This change migrates the templates to the maintained Eclipse Temurin images discussed in #319.
Which issue(s) this PR fixes
Fixes #319
How Has This Been Tested?
Built and ran a test function for each template with
faas-cli local-run --build.The
java11andjava17functions returned HTTP 200 withHello, world!. Thejava11-vert-xfunction returned HTTP 200 with{"status":"ok"}.Types of changes
Impact to existing users
Functions rebuilt from these Java templates will use Eclipse Temurin on Ubuntu Noble instead of the removed OpenJDK images. The runtime stages remain JRE-based, and existing deployed images are unaffected.
Checklist:
git commit -s