Remove the armhf binary from the release - #1027
AI Code Review Results
AI Pull Request Overview
Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.
Summary
- Removes the Linux ARMHF redistributable binary from the release image and extraction script.
- Removes ARMHF-specific CI Makefile targets and ignore entries.
- Updates npm suffix behavior so 32-bit Arm platforms fail as unsupported instead of targeting a missing asset.
- Adds coverage in the build workflow for the redistributable Dockerfile cross-compile path.
- Updates contributor documentation to match the reduced release artifact set.
- No blocking correctness, release, or publishing issues were found in the scoped diff.
Approval rating (1-10)
9/10. The change is focused, consistent across release paths, and adds useful CI coverage for the remaining redistributable targets.
Summary per file
Summary per file
| File path | Summary |
|---|---|
.github/workflows/build.yaml |
Adds Dockerfile.redist build coverage to regular CI. |
.gitignore |
Stops ignoring the removed ARMHF binary. |
CONTRIBUTING.md |
Updates release binary documentation to omit ARMHF. |
Dockerfile.redist |
Removes the ARMHF build stage and release copy. |
Makefile |
Removes ARMHF image build and push targets. |
build_integration_test.sh |
Removes ARMHF binary selection for Linux armv6/armv7. |
commands/local_run_resources.go |
Generalizes the 32-bit overflow comment. |
extract_binaries.sh |
Stops extracting the removed ARMHF artifact. |
npm/lib.js |
Stops mapping 32-bit Arm to an ARMHF release suffix. |
npm/test.js |
Updates suffix tests to expect unsupported 32-bit Arm. |
Overall Assessment
The PR consistently removes the ARMHF CLI release artifact from the redistributable build, extraction, local ignore list, contributor docs, and npm install suffix handling. Adding Dockerfile.redist to the regular build workflow directly addresses the prior gap where cross-compiled release binaries were only validated during publishing. I did not find a concrete regression in the scoped diff.
Detailed Review
Detailed Review
No blocking findings.
The release path remains internally consistent: Dockerfile.redist no longer produces faas-cli-armhf, extract_binaries.sh no longer copies it, and the GitHub release upload glob will publish the remaining faas-cli* assets.
The npm behavior now fails before attempting to download a removed 32-bit Arm artifact. That matches the stated user impact better than leaving installers to fail with a release-asset 404.
The build workflow addition targets the release stage of Dockerfile.redist, which forces the remaining Linux, macOS, Windows, and arm64 binary stages referenced by that stage to compile before release time.
The documentation update in CONTRIBUTING.md matches the final artifact set and does not introduce a reader-facing inconsistency.
AI agent details.
Agent processing time: 1m14.76s
Environment preparation time: 3.279s
Total time from webhook: 1m23.547s