Skip to content

build: enable ruff rule sets F, PT, DJ, UP, and B #38291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feanil merged 9 commits into from
Apr 9, 2026

style: suppress pylint line-too-long on lines made long by noqa comments

938a888
Select commit
Loading
Failed to load commit list.
Merged

build: enable ruff rule sets F, PT, DJ, UP, and B #38291

style: suppress pylint line-too-long on lines made long by noqa comments
938a888
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Apr 9, 2026 in 2s

144 new alerts including 36 high severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 36 high
  • 108 medium

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 952 in lms/djangoapps/discussion/rest_api/tests/utils.py

See this annotation in the file changed.

Code scanning / CodeQL

Use of a broken or weak cryptographic hashing algorithm on sensitive data High test

Sensitive data (id)
Loading
is used in a hashing algorithm (MD5) that is insecure.

Check failure on line 1097 in lms/djangoapps/discussion/django_comment_client/utils.py

See this annotation in the file changed.

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<p ' and with many repetitions of '<p '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '' and with many repetitions of 'a'.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<p ' and with many repetitions of '<p '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '' and with many repetitions of 'a'.

Check failure on line 1092 in lms/djangoapps/discussion/django_comment_client/utils.py

See this annotation in the file changed.

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<img ' and with many repetitions of '<img '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<img src="!" ' and with many repetitions of '= src="!" '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<img src="!" ' and with many repetitions of '= '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<img src="!" ' and with many repetitions of '= '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<img ' and with many repetitions of '<img '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<img src="!" ' and with many repetitions of '= src="!" '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<img src="!" ' and with many repetitions of '= '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<img src="!" ' and with many repetitions of '= '.

Check failure on line 1073 in lms/djangoapps/discussion/django_comment_client/utils.py

See this annotation in the file changed.

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<a ' and with many repetitions of '<a '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<a href="!" ' and with many repetitions of '= href="!" '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<a href="!" ' and with many repetitions of '= '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '' and with many repetitions of 'a'.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<a ' and with many repetitions of '<a '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<a href="!" ' and with many repetitions of '= href="!" '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '<a href="!" ' and with many repetitions of '= '.
This
regular expression
Loading
that depends on a
user-provided value
Loading
may run slow on strings starting with '' and with many repetitions of 'a'.

Check failure on line 1208 in lms/djangoapps/certificates/models.py

See this annotation in the file changed.

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
Loading
.

Check failure on line 1207 in lms/djangoapps/certificates/models.py

See this annotation in the file changed.

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
Loading
.

Check failure on line 71 in lms/djangoapps/certificates/admin.py

See this annotation in the file changed.

Code scanning / CodeQL

Incomplete URL substring sanitization High

The string
.stage.edx.org
Loading
may be at an arbitrary position in the sanitized URL.

Check failure on line 233 in lms/djangoapps/branding/api.py

See this annotation in the file changed.

Code scanning / CodeQL

Incomplete URL substring sanitization High

The string
support.edx.org
Loading
may be at an arbitrary position in the sanitized URL.

Check failure on line 87 in openedx/core/djangoapps/oauth_dispatch/management/commands/create_dot_application.py

See this annotation in the file changed.

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (secret)
Loading
as clear text.

Check failure on line 110 in common/djangoapps/student/tests/test_models.py

See this annotation in the file changed.

Code scanning / CodeQL

Use of a broken or weak cryptographic hashing algorithm on sensitive data High test

Sensitive data (id)
Loading
is used in a hashing algorithm (MD5) that is insecure.

Check failure on line 99 in common/djangoapps/student/tests/test_models.py

See this annotation in the file changed.

Code scanning / CodeQL

Use of a broken or weak cryptographic hashing algorithm on sensitive data High test

Sensitive data (id)
Loading
is used in a hashing algorithm (MD5) that is insecure.

Check failure on line 81 in common/djangoapps/student/tests/test_models.py

See this annotation in the file changed.

Code scanning / CodeQL

Use of a broken or weak cryptographic hashing algorithm on sensitive data High test

Sensitive data (id)
Loading
is used in a hashing algorithm (MD5) that is insecure.

Check failure on line 1015 in common/djangoapps/student/models/course_enrollment.py

See this annotation in the file changed.

Code scanning / CodeQL

Use of a broken or weak cryptographic hashing algorithm on sensitive data High

Sensitive data (id)
Loading
is used in a hashing algorithm (MD5) that is insecure.

Check warning on line 203 in openedx/core/djangoapps/embargo/api.py

See this annotation in the file changed.

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.

Check warning on line 1160 in lms/djangoapps/verify_student/views.py

See this annotation in the file changed.

Code scanning / CodeQL

Reflected server-side cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
Loading
.

Check warning on line 1093 in lms/djangoapps/verify_student/views.py

See this annotation in the file changed.

Code scanning / CodeQL

Reflected server-side cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
Loading
.

Check warning on line 1054 in lms/djangoapps/verify_student/views.py

See this annotation in the file changed.

Code scanning / CodeQL

Reflected server-side cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
Loading
.

Check warning on line 1050 in lms/djangoapps/verify_student/views.py

See this annotation in the file changed.

Code scanning / CodeQL

Reflected server-side cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
Loading
.

Check warning on line 244 in lms/djangoapps/support/views/enrollments.py

See this annotation in the file changed.

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.

Check warning on line 213 in lms/djangoapps/support/views/enrollments.py

See this annotation in the file changed.

Code scanning / CodeQL

Reflected server-side cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
Loading
.

Check warning on line 205 in lms/djangoapps/support/views/enrollments.py

See this annotation in the file changed.

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.

Check warning on line 172 in lms/djangoapps/support/views/enrollments.py

See this annotation in the file changed.

Code scanning / CodeQL

Reflected server-side cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
Loading
.

Check warning on line 162 in lms/djangoapps/support/views/enrollments.py

See this annotation in the file changed.

Code scanning / CodeQL

Reflected server-side cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
Loading
.
Cross-site scripting vulnerability due to a
user-provided value
Loading
.

Check warning on line 156 in lms/djangoapps/support/views/enrollments.py

See this annotation in the file changed.

Code scanning / CodeQL

Reflected server-side cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
Loading
.

Check warning on line 149 in lms/djangoapps/support/views/enrollments.py

See this annotation in the file changed.

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.