-
Notifications
You must be signed in to change notification settings - Fork 25
feat: New history log api functions [FC-0123]
#501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+985
−6
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6f4b1dc
feat: `get_entity_draft_history` added
ChrisChV c492314
feat: contributors, publish groups and publish entries functions added
ChrisChV 3823f5a
fix: return draft and published entries of a component with discarted…
ChrisChV 8e270a7
feat: Pre-fetch the component type in the queries
ChrisChV 723fe11
feat: get_descendant_component_entity_ids function added
ChrisChV 1fefef3
Merge branch 'main' into chris/FAL-4330-history-log
ChrisChV 4ac8d44
refactor: Update `get_descendant_component_entity_ids` to avoid use `…
ChrisChV bafab85
Merge branch 'main' into chris/FAL-4330-history-log
ChrisChV 6b423f2
fix: Broken lints
ChrisChV 6ac9384
Merge branch 'main' into chris/FAL-4330-history-log
ChrisChV ddf5ff7
fix: Broken tests
ChrisChV 3704bfe
feat: order contributors by most recent contribution first
ChrisChV 03fc733
Merge branch 'main' into chris/FAL-4330-history-log
ChrisChV 5fa8b6b
refactor: Remove `entity__component__component_type` from history log…
ChrisChV fd887b6
style: Add `UNSTABLE` comment in history log functions
ChrisChV 9339c31
chore: Upgrade version to 0.44.0
ChrisChV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the intended behavior of this function when the last "publish" was a deletion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current code does work in this case, to be clear. And I realize that it's not something that's likely to come up in the UX. I just want to make sure that the behavior is well defined and tested for in that edge case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yes, I'll add tests for that case.