Skip to content

feat(httproute): add optional kind and group fields to parentRefs #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierre-jezegou wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(httproute): add optional kind and group fields to parentRefs #349

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe1f265
feat(httproute): add optional kind and group fields to parentRefs
May 10, 2026
9964686
fix(HTTPRoute): fix whitespace trimming and quote kind/group in paren…
May 15, 2026
9b7a9be
chore(chart): bump patch version
May 15, 2026
38e24e1
fix(HTTPRoute): fix whitespace trimming and quote kind/group in paren…
May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions charts/opencost/templates/httproute.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ spec:
parentRefs:
{{- range .Values.opencost.ui.httpRoute.parentRefs }}
- name: {{ .name }}
{{- if .kind }}
kind: {{ .kind }}
{{- end }}
{{- if .group }}
group: {{ .group }}
Comment thread
pierre-jezegou marked this conversation as resolved.
Outdated
Comment thread
pierre-jezegou marked this conversation as resolved.
Outdated
{{- end }}
{{- if .namespace }}
namespace: {{ .namespace }}
{{- end }}
Expand Down Expand Up @@ -59,6 +65,12 @@ spec:
parentRefs:
{{- range .Values.opencost.exporter.apiHttpRoute.parentRefs }}
- name: {{ .name }}
{{- if .kind }}
kind: {{ .kind }}
{{- end }}
{{- if .group }}
group: {{ .group }}
{{- end }}
{{- if .namespace }}
namespace: {{ .namespace }}
{{- end }}
Expand Down Expand Up @@ -103,6 +115,12 @@ spec:
parentRefs:
{{- range .Values.opencost.mcp.httpRoute.parentRefs }}
- name: {{ .name }}
{{- if .kind }}
kind: {{ .kind }}
{{- end }}
{{- if .group }}
group: {{ .group }}
Comment thread
pierre-jezegou marked this conversation as resolved.
Outdated
{{- end }}
{{- if .namespace }}
namespace: {{ .namespace }}
{{- end }}
Expand Down
6 changes: 6 additions & 0 deletions charts/opencost/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,8 @@ opencost:
# @default -- See [values.yaml](values.yaml)
parentRefs:
- name: ""
# kind: ""
# group: ""
Comment on lines +259 to +260

@thomasvn thomasvn May 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That default is not determined by this Helm chart. Closing comment.

@thomasvn thomasvn May 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we shouldn't set the default ourselves in the values.yaml. A comment here may help users? @pierre-jezegou?

parentRefs:
  - name: ""
    # kind: "Gateway"  # Default when omitted
    # group: "gateway.networking.k8s.io"  # Default when omitted

namespace: ""
sectionName: ""
# -- Hostnames for the HTTPRoute
Expand Down Expand Up @@ -450,6 +452,8 @@ opencost:
# @default -- See [values.yaml](values.yaml)
parentRefs:
- name: ""
# kind: ""
# group: ""
namespace: ""
sectionName: ""
# -- Hostnames for the HTTPRoute
Expand Down Expand Up @@ -751,6 +755,8 @@ opencost:
# @default -- See [values.yaml](values.yaml)
parentRefs:
- name: ""
# kind: ""
# group: ""
namespace: ""
sectionName: ""
# -- Hostnames for the HTTPRoute
Expand Down
Loading