Skip to content

fix(design-system): silence OcDrop attr-inheritance warning storm #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JammingBen merged 2 commits into from
May 20, 2026
Merged

fix(design-system): silence OcDrop attr-inheritance warning storm #2560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97f68d7
fix(design-system): silence OcDrop attr-inheritance warning storm
dschmidt May 19, 2026
2c20470
test(design-system): refresh OcDrop snapshots after inheritAttrs flip
dschmidt May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/design-system/src/components/OcDrop/OcDrop.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<Teleport :disabled="!teleport" :to="teleport ? teleport : undefined">
<div
v-if="isOpen"
v-bind="attrs"
:id="dropId"
ref="drop"
class="oc-drop shadow-sm/10 rounded-xl bg-role-surface border border-role-surface-container-highest"
Expand Down Expand Up @@ -156,6 +157,12 @@ const {
const emit = defineEmits<Emits>()
defineSlots<Slots>()

// Suppress Vue's auto-inheritance — OcDrop's root is a fragment
// (oc-mobile-drop OR Transition+Teleport). Without this, every parent
// pass-through (class, role, ...) flushes a console.warn per render.
// `attrs.class` is forwarded manually to the inner div below.
defineOptions({ inheritAttrs: false })

const attrs = useAttrs()
const { registerEventListener, unregisterEventListeners } = useEventListeners()
const { isMobile } = useIsMobile()
Expand Down
6 changes: 3 additions & 3 deletions packages/web-app-files/tests/unit/components/Spaces/__snapshots__/SpaceHeader.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports[`SpaceHeader > should add the "squashed"-class when the sidebar is opene
return svg;
}" aria-hidden="true" focusable="false" class="size-5"></svg></span>
</button>
<transition-stub name="oc-drop" appear="false" persisted="false" css="true" options="[object Object]">
<transition-stub name="oc-drop" appear="false" persisted="false" css="true">
<!--teleport start-->
<!--v-if-->
<!--teleport end-->
Expand Down Expand Up @@ -61,7 +61,7 @@ exports[`SpaceHeader > space description > should show the description 1`] = `
return svg;
}" aria-hidden="true" focusable="false" class="size-5"></svg></span>
</button>
<transition-stub name="oc-drop" appear="false" persisted="false" css="true" options="[object Object]">
<transition-stub name="oc-drop" appear="false" persisted="false" css="true">
<!--teleport start-->
<!--v-if-->
<!--teleport end-->
Expand Down Expand Up @@ -106,7 +106,7 @@ exports[`SpaceHeader > space image > should show the set image 1`] = `
return svg;
}" aria-hidden="true" focusable="false" class="size-5"></svg></span>
</button>
<transition-stub name="oc-drop" appear="false" persisted="false" css="true" options="[object Object]">
<transition-stub name="oc-drop" appear="false" persisted="false" css="true">
<!--teleport start-->
<!--v-if-->
<!--teleport end-->
Expand Down
6 changes: 3 additions & 3 deletions ...web-pkg/tests/unit/components/ContextActions/__snapshots__/ContextActionMenu.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ exports[`ContextActionMenu component > renders the menu with drop menu items 1`]
return svg;
}" aria-hidden="true" focusable="false" class="size-4"></svg></span>
</button>
<transition-stub name="oc-drop" appear="false" persisted="false" css="true" class="w-3xs oc-files-context-action-drop">
<transition-stub name="oc-drop" appear="false" persisted="false" css="true">
<!--teleport start-->
<!--teleport end-->
</transition-stub>
Expand Down Expand Up @@ -63,7 +63,7 @@ exports[`ContextActionMenu component > renders the menu with drop menu items 1`]
return svg;
}" aria-hidden="true" focusable="false" class="size-4"></svg></span>
</button>
<transition-stub name="oc-drop" appear="false" persisted="false" css="true" class="w-3xs oc-files-context-action-drop">
<transition-stub name="oc-drop" appear="false" persisted="false" css="true">
<!--teleport start-->
<!--teleport end-->
</transition-stub>
Expand All @@ -88,7 +88,7 @@ exports[`ContextActionMenu component > renders the menu with drop menu items 1`]
return svg;
}" aria-hidden="true" focusable="false" class="size-4"></svg></span>
</button>
<transition-stub name="oc-drop" appear="false" persisted="false" css="true" class="w-3xs oc-files-context-action-drop">
<transition-stub name="oc-drop" appear="false" persisted="false" css="true">
<!--teleport start-->
<!--teleport end-->
</transition-stub>
Expand Down