fix: apply surrogate-pair fixup in encode_with_unstable#575
Open
steps-re wants to merge 1 commit into
Open
Conversation
encode_with_unstable raised UnicodeEncodeError when given text containing surrogate pairs (e.g. "👍"), while encode and encode_ordinary handled the same input correctly by catching UnicodeEncodeError and re-encoding through UTF-16 surrogatepass. Apply the same try/except fixup to encode_with_unstable so all three methods behave consistently for surrogate-pair inputs. Fixes openai#541 Signed-off-by: Mike German <mike@stepsventures.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #541.
encodeandencode_ordinaryboth catchUnicodeEncodeErrorand re-encode the text through UTF-16 surrogatepass before retrying, so they handle strings containing surrogate pairs (e.g."👍") correctly.encode_with_unstablewas missing the same try/except, causing it to raiseUnicodeEncodeErroron identical input.Change: wrap the inner
_core_bpe.encode_with_unstablecall in the same try/except thatencodeuses.Test:
test_encode_with_unstable_surrogate_pairsintests/test_encoding.pyverifies that:"👍").encode.