Skip to content

filter drop targets - #1117

Merged
benderl merged 2 commits into
openWB:mainfrom
benderl:nested-list-drop-filter
Oct 8, 2026
Merged

benderl merged 2 commits into
openWB:mainfrom
benderl:nested-list-drop-filter

Conversation

@benderl

@benderl benderl commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

modify nested list component to:

  • only show drop target if valid for the current component type
  • only allow nesting of batteries inside inverters
image

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Battery drops are still accepted by group and counter targets, contrary to the stated nesting restriction.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Updates the nested list to filter valid drop targets and enforce component-specific nesting rules.

Changes:

  • Filters visible nested drop targets by component type.
  • Adds drag-and-drop validation.
  • Restricts inverter nesting to batteries.
File Summary
src/​components/​OpenwbNestedList.vue Implements filtered drop targets and nesting validation; battery drops into groups or counters still require correction.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/components/OpenwbNestedList.vue
@benderl
benderl requested a review from Brett-S-OWB October 6, 2026 14:21
@benderl benderl self-assigned this Oct 6, 2026
@benderl
benderl merged commit 7a68d8b into openWB:main Oct 8, 2026
1 check passed
@benderl
benderl deleted the nested-list-drop-filter branch October 9, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants