Repository navigation
filter drop targets - #1117
Merged
Merged
filter drop targets#1117
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Battery drops are still accepted by group and counter targets, contrary to the stated nesting restriction.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates the nested list to filter valid drop targets and enforce component-specific nesting rules.
Changes:
- Filters visible nested drop targets by component type.
- Adds drag-and-drop validation.
- Restricts inverter nesting to batteries.
| File | Summary |
|---|---|
src/components/OpenwbNestedList.vue |
Implements filtered drop targets and nesting validation; battery drops into groups or counters still require correction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Brett-S-OWB
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

modify nested list component to: