Update: Hausverbrauch Zähler - #3991
Merged
LKuemmel merged 2 commits intoSep 23, 2026
Hidden character warning
The head ref may contain hidden characters: "update_hausverbrauchsz\u00e4hler"
Merged
Conversation
AlexanderHa98
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new start mode makes EVU counters configured as AUTO behave differently and inconsistently with existing root-AUTO semantics in the same module.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adjusts the “Hausverbrauch” (home consumption) calculation in CounterAll by changing the initial mode used when starting the recursion at the EVU counter.
Changes:
- Start home-consumption recursion with
HOME_CONSUMPTIONinstead ofNOT_HOME_CONSUMPTION.
| File | Description |
|---|---|
| packages/control/counter_all/counter_all.py | Changes the initial CounterMode used when computing home consumption from the EVU-rooted hierarchy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
169
to
+170
| # Rekursion startet immer beim EVU-Zähler. | ||
| home_consumption = self._calc_home_consumption_from_counter(evu_element, CounterMode.NOT_HOME_CONSUMPTION.value) | ||
| home_consumption = self._calc_home_consumption_from_counter(evu_element, CounterMode.HOME_CONSUMPTION.value) |
LKuemmel
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openWB/openwb-ui-settings#1101
https://github.com/openWB/internal-projects/issues/366