Skip to content

AlphaKit Protoss restart #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 2 commits into from
Oct 27, 2025
Merged

AlphaKit Protoss restart #2853

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdb02c7
add ip_address
ndrsnhs Oct 24, 2025
2b7b49a
add proper restart for different modules
ndrsnhs Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/modules/devices/alpha_ess/alpha_ess/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def initializer():
device_config.configuration.ip_address, device_config.configuration.port)

def error_handler():
run_command(f"{Path(__file__).resolve().parents[4]}/modules/common/restart_protoss_admin")
run_command((f"{Path(__file__).resolve().parents[4]}/modules/common/restart_protoss_admin 192.168.193.125"))

@tpd-opitz tpd-opitz Oct 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ob eine fixe IP hier wirklich zielführend ist?

@ndrsnhs ndrsnhs Oct 24, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was spricht dagegen und welchen Vorteil hätte es das an dieser Stelle variabel zu gestalten?

@tpd-opitz tpd-opitz Oct 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diese IP gilt nur in Deinem Netzwerk, nirgendwo sonst.

@ndrsnhs ndrsnhs Oct 24, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die IP des AlphaESS Kit wird werkseitig fix vergeben und ist in Z.58 ebenfalls hart codiert. Bei einem AlphaESS mit nativem LAN Anschluss lässt sich kein Protoss neu starten (gibt es nicht), daher spielt das dort keine Rolle.
Kunden könnten sicher ihren eigenen Protoss konfigurieren der dann natürlich eine andere IP hätte aber da funktioniert das Skript wegen Login Credentials ebenfalls nicht.

@tpd-opitz tpd-opitz Oct 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, war mir nicht klar, dass es Firmen gibt, die so einen Unsinn machen...


return ConfigurableDevice(
device_config=device_config,
Expand Down