GAZ-319: Default OutboundMessages.type to "sms" for type-less clients - #86
Merged
Merged
Conversation
Contributor
Author
|
Hey @tdaly-mifos, please take a look at this PR. |
tdaly61
approved these changes
Aug 9, 2026
tdaly61
added a commit
to openMF/mifos-gazelle
that referenced
this pull request
Aug 9, 2026
**Summary** Adds the openMF message-gateway (SMS & messaging) component to the MifosX deployment: - `message-gateway-deployment.yaml`: Deployment with an initContainer that creates the `messagegateway` DB on the shared Postgres; container on ports 9191 (REST/actuator) + 5009 (Camel callback); actuator health probes. - `message-gateway-service.yaml`: ClusterIP Service (9191 + 5009). - `infra/values.yaml`: `CREATE DATABASE messagegateway` in the Postgres init. Verified via `./run.sh -m deploy -a mifosx`: pod healthy on the shared Postgres, Flyway applies the Postgres migrations, and a Dummy-provider send returns DELIVERED. **Note** Image is openmf/message-gateway:`dev-51abedb`, the official CI build from dev after both message-gateway PRs merged ([#85 Postgres](openMF/message-gateway#85) +[ #86 type fix)](openMF/message-gateway#86). Verified on the cluster: Fineract SMS campaign → gateway → DELIVERED end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fineract 1.14's SMS payload (
SmsMessageApiQueueResourceData) has notypefield, butOutboundMessages.typeis@Column(nullable=false), so every classic Fineract SMS campaign 500s against the gateway (HibernatePropertyValueException). This defaultstypeto"sms"so type-less clients persist; the email path still sets"email"explicitly.Pre-existing (fails identically on MySQL) and independent of the Postgres work (#85), the classic Fineract SMS path appears never to have been exercised against this PHEE-flavored gateway.
Testing
Verified against Fineract's exact type-less payload:
POST /smsnow returns 202 and stores the row (typedefaults tosms), where it previously returned 500. Regression: an explicittype=emailpayload is still stored withtype=email.