Skip to content

Fix/dockerfile third party notices#2613

Merged
jmacd merged 2 commits intoopen-telemetry:mainfrom
jmacd:fix/dockerfile-third-party-notices
Apr 8, 2026
Merged

Fix/dockerfile third party notices#2613
jmacd merged 2 commits intoopen-telemetry:mainfrom
jmacd:fix/dockerfile-third-party-notices

Conversation

@jmacd
Copy link
Copy Markdown
Contributor

@jmacd jmacd commented Apr 8, 2026

Change Summary

Adds a necessary Dockerfile line to fix the build.
Adds a test to our CI/CD workflow, which would have caught this in #2597.
This was going to block #2515

jmacd and others added 2 commits April 8, 2026 13:32
main.rs but the Dockerfile was not updated to copy the file from the
otel-arrow build context, breaking the Docker build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Dockerfile is not validated by any PR-triggered CI workflow.
Breakages (like a missing COPY for THIRD_PARTY_NOTICES.txt) go
undetected until a nightly or manual perf-test run fails.

Add a path-filtered workflow that builds the Docker image on PRs
touching the Dockerfile, source, or build-related files.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jmacd jmacd requested a review from a team as a code owner April 8, 2026 20:43
@github-actions github-actions bot added rust Pull requests that update Rust code ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores labels Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.36%. Comparing base (e1742e0) to head (4bc3cfa).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
- Coverage   88.37%   88.36%   -0.01%     
==========================================
  Files         620      620              
  Lines      228395   228395              
==========================================
- Hits       201836   201830       -6     
- Misses      26035    26041       +6     
  Partials      524      524              
Components Coverage Δ
otap-dataflow 90.20% <ø> (-0.01%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.74% <ø> (ø)
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 52.45% <ø> (ø)
quiver 92.27% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacd jmacd enabled auto-merge April 8, 2026 20:56
@jmacd jmacd disabled auto-merge April 8, 2026 20:56
@jmacd jmacd enabled auto-merge April 8, 2026 21:07
@jmacd jmacd added this pull request to the merge queue Apr 8, 2026
Merged via the queue into open-telemetry:main with commit 0eb5048 Apr 8, 2026
68 of 70 checks passed
@jmacd jmacd deleted the fix/dockerfile-third-party-notices branch April 8, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants