fix: resolve pipeline-perf-test-basic CI failures (#2511)#2605
Closed
jmacd wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
fix: resolve pipeline-perf-test-basic CI failures (#2511)#2605jmacd wants to merge 1 commit intoopen-telemetry:mainfrom
jmacd wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Fix two distinct failures in the pipeline-perf-test-basic CI job: to main.rs, but the Dockerfile did not copy this file into the build context. Add the missing COPY line. 2. DrainDeadlineReached on ubuntu-latest: The basic validation job was running the same 100k signals/sec config as dedicated 64-core hardware. On shared CI runners (4 vCPUs), the pipeline cannot drain ~2.5M queued signals within the 60s timeout. Create a lightweight 1k signals/sec config for correctness validation and use it for the basic job. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
bot
added
rust
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2605 +/- ##
==========================================
+ Coverage 88.42% 88.45% +0.02%
==========================================
Files 620 620
Lines 228395 228395
==========================================
+ Hits 201961 202017 +56
+ Misses 25910 25854 -56
Partials 524 524
🚀 New features to boost your workflow:
|
cijothomas
reviewed
Apr 8, 2026
| run: | | ||
| cd tools/pipeline_perf_test | ||
| python orchestrator/run_orchestrator.py --config test_suites/integration/continuous/100klrps-docker.yaml | ||
| python orchestrator/run_orchestrator.py --config test_suites/integration/continuous/1klrps-docker.yaml |
Member
There was a problem hiding this comment.
when performance label is added, this one is run on the lab machine, so we'd want to conditionally pick based on the label or not.
Member
|
#2515 is needed to fix entire perf test suites - all of them stuck in shutdown failure. |
1 task
Contributor
Author
|
In favor of #2511 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix two distinct failures in the pipeline-perf-test-basic CI job:
to main.rs, but the Dockerfile did not copy this file into the build context.
Add the missing COPY line.
What issue does this PR close?
Fixes #2511
if we're lucky
How are these changes tested?
🤞
Are there any user-facing changes?
No