Fix nightly benchmark publishing when some test suites fail#2541
Merged
albertlockett merged 1 commit intoopen-telemetry:mainfrom Apr 6, 2026
Merged
Conversation
- Add if: !cancelled() to update-benchmarks job so it runs even when pipeline-perf-test has failures - Add if: !cancelled() to syslog TCP upload step (was the only upload step missing it) - Add if: !cancelled() to all consolidation steps in update-benchmarks - Add if: !cancelled() && hashFiles() guard to all publish steps so each suite publishes independently and skips cleanly when no data exists - Change scaling-efficiency download to use pattern/merge-multiple instead of exact name match to avoid failure when artifact is missing - Update consolidate-benchmarks.sh to exit gracefully when input directory is empty or missing
github-actions
bot
added
the
ci-repo
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2541 +/- ##
==========================================
- Coverage 88.34% 88.34% -0.01%
==========================================
Files 613 613
Lines 222675 222675
==========================================
- Hits 196731 196725 -6
- Misses 25420 25426 +6
Partials 524 524
🚀 New features to boost your workflow:
|
lalitb
approved these changes
Apr 5, 2026
drewrelmas
approved these changes
Apr 5, 2026
albertlockett
approved these changes
Apr 5, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
open-telemetry:main
with commit Apr 6, 2026
5247a88
117 of 119 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures passing test suite results are still published to benchmark pages even when other suites fail.