[otap-dataflow] add transport header infrastructure#2539
Open
c1ly wants to merge 2 commits intoopen-telemetry:mainfrom
Open
[otap-dataflow] add transport header infrastructure#2539c1ly wants to merge 2 commits intoopen-telemetry:mainfrom
c1ly wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
…des and propagating headers in exporter nodes. Exposed helper capture and propagation tools in the effect_handler for receiver and exporter nodes to use
… to be pub(crate)
Comment on lines
+77
to
+79
| if result.len() >= defaults.max_entries { | ||
| break; | ||
| } |
Member
There was a problem hiding this comment.
I wonder if the signature of this method should return some feedback about whether we failed to consume some of the pairs? Otherwise, it becomes a bit cumbersome, because we'd need to check a) that the pairs iter was consumed and b) that the result length is equal to the iter that was passed.
Maybe a different signature could be something like:
pub fn capture_from_pairs<'a>(
&self,
headers: &mut TransportHeaders
pairs: impl Iterator<Item = (&'a str, &'a [u8])>,
) -> Result<()> {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Update the OtapPdata Context with the transport_headers field, so that OtapPdata can carry the headers through the pipeline.
Defined the TransportHeadersPolicy with HeaderCapturePolicy and HeaderPropagationPolicy, update the Policies to have a transport_headers field. Receiver and Exporter nodes can also define HeaderCapturePolicy and HeaderPropagationPolicy respectively, these definitions will override any top level HeaderCapturePolicy and HeaderPropagationPolicy rules.
Exposed the policy to the Receiver and Exporter nodes via the EffectHandler with helper functions that apply the policies on a iterator of key value pairs (for receiver nodes) and transport_headers (for exporter nodes)
What issue does this PR close?
OtapPdata#2508How are these changes tested?
unit tests and integration tests
Are there any user-facing changes?
no