Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2512 +/- ##
==========================================
+ Coverage 88.29% 88.32% +0.03%
==========================================
Files 613 613
Lines 220110 220110
==========================================
+ Hits 194338 194414 +76
+ Misses 25248 25172 -76
Partials 524 524
🚀 New features to boost your workflow:
|
cijothomas
reviewed
Apr 2, 2026
cijothomas
reviewed
Apr 2, 2026
cijothomas
reviewed
Apr 2, 2026
Co-authored-by: Cijo Thomas <[email protected]>
cijothomas
reviewed
Apr 2, 2026
| OpenTelemetry Collector-Contrib distribution since [the July 2024 | ||
| release of v0.104.0][ARROW-RELEASED]. | ||
|
|
||
| Our Rust and Go codebases are both used in production. Our project has |
Member
There was a problem hiding this comment.
used in production
We probably need to add some links/references to make that statement?
cijothomas
reviewed
Apr 2, 2026
| OpenTelemetry Profiles signal in OTAP is important future work. | ||
|
|
||
| In both our Rust and Golang implementations, we support combined OTAP | ||
| and OTLP services on a single port, making OTel-Arrow OTAP/OTLP |
Member
There was a problem hiding this comment.
did you mean we support OTLP and OTAP receiver on a single port? .. This sentence reads a bit odd..
cijothomas
reviewed
Apr 2, 2026
|
|
||
| A [directory of example configurations][EXAMPLE-CONFIGS] provides a | ||
| number of examples (e.g., | ||
| [syslog-console.yaml][SYSLOG-CONSOLE-YAML]). For example, to print |
Member
There was a problem hiding this comment.
to receive syslog messages on port 5140 and then print them to console
cijothomas
reviewed
Apr 2, 2026
| > documentation][SYSLOG-CEF] for secure configuration examples. | ||
|
|
||
| ```bash | ||
| ./target/debug/df_engine -c ./configs/syslog-console.yaml --num-cores=1 |
Member
There was a problem hiding this comment.
nit: maybe we should mention the relevance of --num-cores=1 ? or omit it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Update README to highlight our progress in Phase 2. We did a lot!
Are there any user-facing changes?
Yes. I tested the example commands in this update.