docs(operator): copy sampler and propagation config from operator README#9684
Conversation
|
|
|
Thank you, @gayathri12devi. @open-telemetry/operator-approvers Please have a look. |
|
Thank you for the review, @theletterf! |
|
Hi! |
| The above command results in a deployment of the Collector that you can use as | ||
| an endpoint for auto-instrumentation in your pods. | ||
|
|
||
| ## Deployment Modes |
There was a problem hiding this comment.
It would make more sense to have this in a seprate document. This page should be focused on the auto-instrumentation
| instrumentation.opentelemetry.io/inject-sdk: "true" | ||
| ``` | ||
|
|
||
| ## Target Allocator |
There was a problem hiding this comment.
This should go into the TA docs https://opentelemetry.io/docs/platforms/kubernetes/operator/target-allocator/
|
Thanks for the review! @pavolloffay I've removed the Deployment Modes and Target Allocator sections as suggested |
Hi @gayathri12devi! Thanks for your contribution! We'll definitely help you out with the CI checks. Yes, you can use GitHub actions to fix them on the PR. If you're more comfortable working locally, you can also run the fix commands on your machine and push up the changes. I'll try a GItHub action command now to see how many of the checks we can get passing. |
|
/fix |
|
✅ |
There was a problem hiding this comment.
Hi @gayathri12devi! We reserve this file for words that are widely used. Could you revert the changes you made to this file and instead add them to the cSpell:ignore front matter of the docs page? I'll leave a comment to show you exactly where they need to go.
There was a problem hiding this comment.
Thank you @tiffany76! I wasn't aware of the cSpell:ignore front matter convention. I've committed your suggestion and reverted the changes to cspell/en-words.txt.
|
@tiffany76 I noticed my PR shows some extra words being added to en-words.txt like dotnet, Dyla, dynatrace etc. These were already present in my local fork before I started this PR. I didn't add them intentionally. I also noticed that chalin restructured the cSpell file 2 days ago in the main repo, and my fork still has the older version with those extra words. Should I sync my fork's en-words.txt with the latest main branch to fix this? |
|
@gayathri12devi, try rebasing off the latest main branch. That should fix the cSpell issue. 🤞 |
Closes open-telemetry#2341 The operator README contains configuration docs for sampler and propagation that were missing from the official docs site at https://opentelemetry.io/docs/platforms/kubernetes/operator/automatic/ Instead of linking out to the operator repo, this commit copies the following sections directly into automatic.md as requested: 1. Deployment modes and sidecar injection 2. Upgrade Strategy 3. Multi-container pod instrumentaion 4. Customized/vendor instrumentaion 5. Apache HTTPD and Nginx auto-instrumentation 6. Target Allocator 7. Controlling instrumentation capabilities 8. Resource attributes configuration
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
a38b315 to
edd9559
Compare
|
@tiffany76 Done! I've rebased my branch on top of the latest main. |
|
@tiffany76 The /docs/specs/semconv/non-normative/k8s-attributes.md path doesn't seem to exist in the repo and is causing the CHECK LINKS failure. Should I revert it back to the original external GitHub URL. Also, the CSPELL word lists check is suggesting to run /fix:dict should I go ahead and do that? |
|
@gayathri12devi Yes, please run fix:dict locally and push up any changes. It will adjust the front matter formatting. As for the link, the page exists. The problem is the .md. Change the link to /docs/specs/semconv/non-normative/k8s-attributes/ and it should work. |
tiffany76
left a comment
There was a problem hiding this comment.
LGTM. @pavolloffay, PTAL before we merge.
|
Thank you for your contribution @gayathri12devi! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Closes #2341
This PR copied the configuration docs from the operator README into the automatic.md page as requested by the maintainers in the issue.
This commit copies the following sections into automatic.md :
Footnotes
Yes, I can answer maintainer questions about the content of this PR, without using AI. ↩