Repository navigation
fix(sender-jdk): unwrap CompletionException and UncheckedIOException before passing to onError - #8987
Closed
siddiqueirshad wants to merge 2 commits into
Conversation
|
Pull request dashboard statusClosed · refreshed 2026-10-29 21:16 UTC Status above doesn't look right?
|
Member
|
Duplicate of #8963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8961
JdkHttpSender.send()executessendInternal(messageWriter)asynchronously viaCompletableFuture.supplyAsync(..., executorService).When an
IOExceptionis encountered during transmission:supplyAsynccatches the thrownUncheckedIOException(e)and completes the stage exceptionally with aCompletionException..whenComplete(...),throwableis aCompletionExceptionwrappingUncheckedIOExceptionwrapping the underlyingIOException(such asConnectException,SocketTimeoutException).CompletionExceptiondirectly toonError.accept(throwable)causesHttpExporterto recorderror.type=java.util.concurrent.CompletionExceptioninstead of the actual transport failure type, and masks the true cause inFailedExportException.In contrast,
OkHttpHttpSenderpasses the unwrappedIOExceptiondirectly fromonFailuretoonError.Solution
In
JdkHttpSender.whenComplete, unwrapCompletionExceptionandUncheckedIOExceptionto retrieve the underlying exception before passing it toonError.accept(unwrapped).Updated
JdkHttpSenderTest.send_ioException_callsOnErrorto assert thaterrorRef.get()is directly anIOExceptionmatching the thrown failure.