Skip to content

To remove cross module internal utility usage from trace propagators - #8955

Merged
jack-berg merged 14 commits into
open-telemetry:mainfrom
NithinU2802:fix/trace-propagator-internal-utilities
Oct 29, 2026
Merged

jack-berg merged 14 commits into
open-telemetry:mainfrom
NithinU2802:fix/trace-propagator-internal-utilities

Conversation

@NithinU2802

@NithinU2802 NithinU2802 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

This PR is to resolves a part #6970 by updating the trace-propagators module’s dependency on API internal utility classes.

Changes

  • Add trace-propagators local StringUtils and TemporaryBuffers utilities.
  • Update B3, Jaeger, and OT trace propagators to use the local utilities which are created.
  • Add explicit null accordingly to the files.
  • Did pick methods which are used from the API internal utility classes.

@NithinU2802
NithinU2802 requested a review from a team as a code owner October 18, 2026 08:13
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-29 10:22 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (ba0ba04) to head (4eadaeb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8955      +/-   ##
============================================
+ Coverage     90.31%   90.36%   +0.04%     
- Complexity    10981    10991      +10     
============================================
  Files          1019     1020       +1     
  Lines         30072    30077       +5     
  Branches       3927     3929       +2     
============================================
+ Hits          27160    27179      +19     
+ Misses         1952     1939      -13     
+ Partials        960      959       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@otelbot otelbot Bot added the api-change Changes to public API surface area label Oct 20, 2026
@otelbot

otelbot Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

⚠️ API changes detected — additional maintainer review required

@jack-berg @jkwatson

This PR modifies the public API surface area of the following module(s):

  • opentelemetry-api

Please review the changes in docs/apidiffs/current_vs_latest/ carefully before approving.

@NithinU2802
NithinU2802 requested a review from jack-berg October 20, 2026 07:02
+++ NEW CLASS: PUBLIC(+) FINAL(+) io.opentelemetry.api.impl.TemporaryBuffers (not serializable)
+++ CLASS FILE FORMAT VERSION: 52.0 <- n.a.
+++ NEW SUPERCLASS: java.lang.Object
+++ NEW METHOD: PUBLIC(+) STATIC(+) char[] chars(int)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@jack-berg
jack-berg merged commit 20c7590 into open-telemetry:main Oct 29, 2026
34 checks passed
@otelbot

otelbot Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @NithinU2802! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to public API surface area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants