Skip to content

Drop ASM dependency from NullGaurdsTest #8954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 3 commits into from
Oct 19, 2026
Merged

Drop ASM dependency from NullGaurdsTest #8954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2db604d
Drop ASM dependency from NullGaurdsTest
jack-berg Oct 16, 2026
7a74726
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
jack-berg Oct 19, 2026
f719d59
PR feedback
jack-berg Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions all/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import org.gradle.api.JavaVersion

plugins {
id("otel.java-conventions")
}
Expand All @@ -6,6 +8,7 @@ description = "OpenTelemetry All"
otelJava.moduleName.set("io.opentelemetry.all")
otelJava.requireSuppressWarningsExplanation.set(false)
otelJava.osgiEnabled.set(false)
otelJava.minJavaVersionSupported.set(JavaVersion.VERSION_25)

// Skip ossIndexAudit on test module
tasks.named("ossIndexAudit") {
Expand Down Expand Up @@ -36,10 +39,6 @@ dependencies {
}

testImplementation("com.tngtech.archunit:archunit-junit5")
// NullGuardsTest uses ASM for method-body bytecode scanning. Once the Gradle build toolchain
// bumps to JDK 24+, we can migrate to the built-in java.lang.classfile API and drop these deps.
testImplementation("org.ow2.asm:asm")
testImplementation("org.ow2.asm:asm-tree")
}

// Custom task type for writing artifacts and jars - configuration cache compatible
Expand Down Expand Up @@ -77,16 +76,7 @@ val writeArtifactsAndJars = tasks.register<WriteArtifactsAndJars>("writeArtifact
}

tasks {
// This module depends on all published subprojects (for JaCoCo coverage aggregation and
// arch tests). Since :exporters:http-sender:jdk targets Java 11, the compiler needs
// release 11 to resolve its classes on the classpath.
withType(JavaCompile::class) {
options.release.set(11)
}

val testJavaVersion = project.findProperty("testJavaVersion") as String?
test {
enabled = testJavaVersion != "8"
dependsOn(writeArtifactsAndJars)
environment("ARTIFACTS_AND_JARS", artifactsAndJarsFile.get().asFile.absolutePath)
}
Expand Down
Loading
Loading