Repository navigation
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-10-30 03:36 UTC Move out of draft to request review. Status above doesn't look right?
|
Copilot
AI
changed the title
[WIP] Delete old deprecated implementations for breaking changes
Replace gRPC header selectors with exact-name capture lists
Oct 30, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change to exact-name gRPC header capture lists.
No open issues 🎉
What changed in this PR
This PR replaces gRPC request-header selectors with exact-name capture lists for 3.0, building on the header naming changes in #20985 across library and javaagent instrumentation.
Changes:
- Replaces selector-based configuration and builder APIs with client/server header-name lists; unset or empty lists capture nothing.
- Removes wildcard and exclusion selection while preserving case-insensitive matching, multiple values, and binary/pseudo-header exclusions.
- Updates tests, configuration references, and breaking-change documentation.
| File | Description |
|---|---|
instrumentation/grpc-1.6/testing/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/AbstractGrpcTest.java |
Checks multiple captured values and omission of unlisted headers. |
instrumentation/grpc-1.6/README.md |
Documents exact-name capture settings and defaults. |
instrumentation/grpc-1.6/metadata.yaml |
Replaces selector metadata with list-valued settings. |
instrumentation/grpc-1.6/library/src/test/java/io/opentelemetry/instrumentation/grpc/v1_6/internal/GrpcConfigTest.java |
Tests list configuration and empty defaults. |
instrumentation/grpc-1.6/library/src/test/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTest.java |
Exercises new builder APIs and disabled capture. |
instrumentation/grpc-1.6/library/src/test/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcAttributesExtractorTest.java |
Tests exact matching, filtering, and wildcard rejection. |
instrumentation/grpc-1.6/library/src/test/java/io/opentelemetry/instrumentation/grpc/v1_6/CapturedGrpcRequestHeadersUtilTest.java |
Removes obsolete selector utility tests. |
instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/internal/GrpcConfig.java |
Reads client/server capture lists. |
instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTelemetryBuilder.java |
Introduces collection-based header capture setters. |
instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcAttributesExtractor.java |
Captures only configured, valid header names. |
instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/CapturedGrpcRequestHeadersUtil.java |
Removes obsolete selector support. |
instrumentation/grpc-1.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/grpc/v1_6/GrpcSingletons.java |
Passes configured lists to the telemetry builder. |
instrumentation/grpc-1.6/javaagent/build.gradle.kts |
Updates agent test properties to capture lists. |
docs/declarative-configuration-example.yaml |
Shows the new list-valued YAML settings. |
declarative-config-bridge/src/test/java/io/opentelemetry/instrumentation/config/bridge/ConfigPropertiesBackedDeclarativeConfigPropertiesTest.java |
Verifies flat-property mapping and empty-list handling. |
CHANGELOG.md |
Documents replacement APIs, settings, and selection behavior. |
Review effort: Balanced
Contributor
|
Are you dropping wildcards because
doesn't that mean just that instrumenations shouldn't capture headers by default not that the captured headers would need to be explicitly named? |
trask
force-pushed
the
copilot/delete-old-deprecated-stuff
branch
from
October 30, 2026 15:43
0210f17 to
f2b9575
Compare
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
force-pushed
the
copilot/delete-old-deprecated-stuff
branch
from
October 30, 2026 15:45
f2b9575 to
d4e27fb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace gRPC request-header selectors with exact-name lists for 3.0; unset or empty lists capture nothing.
.request-headers.included/.excludedwith.request-captured-headers; declarative configuration uses list-valuedjava.grpc.{client,server}.request_captured_headers.setClientRequestHeaders(IncludeExclude)andsetServerRequestHeaders(IncludeExclude)withsetClientRequestCapturedHeaders(Collection<String>)andsetServerRequestCapturedHeaders(Collection<String>).rpc.request.header.<key>string-array attributes, multiple values, and binary/pseudo-header exclusions.