Skip to content

Adopt messaging attribute renames for 3.0 - #21072

Merged
laurit merged 12 commits into
mainfrom
copilot/update-messaging-attributes
Oct 30, 2026
Merged

laurit merged 12 commits into
mainfrom
copilot/update-messaging-attributes

Conversation

Copilot AI commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Renames messaging attributes for 3.0, adopting open-telemetry/semantic-conventions#4251 and open-telemetry/semantic-conventions#4250 and moving the remaining repository-defined experimental attributes into their system namespaces. No compatibility aliases or new flags are introduced.

Old attribute New attribute
messaging.system messaging.system.name
messaging.kafka.bootstrap.servers kafka.bootstrap.servers
messaging.kafka.cluster.id kafka.cluster.id
messaging.kafka.message.key kafka.message.key
messaging.kafka.message.tombstone kafka.message.tombstone
messaging.kafka.offset kafka.offset
messaging.pulsar.message.type pulsar.message.type
messaging.rabbitmq.cluster.name rabbitmq.cluster.name
messaging.rabbitmq.destination.routing_key rabbitmq.destination.routing_key
messaging.rabbitmq.message.delivery_tag rabbitmq.message.delivery_tag
messaging.rabbitmq.vhost.name rabbitmq.vhost.name
messaging.rocketmq.broker_address rocketmq.broker_address
messaging.rocketmq.message.delivery_timestamp rocketmq.message.delivery_timestamp
messaging.rocketmq.message.group rocketmq.message.group
messaging.rocketmq.message.keys rocketmq.message.keys
messaging.rocketmq.message.tag rocketmq.message.tag
messaging.rocketmq.message.type rocketmq.message.type
messaging.rocketmq.namespace rocketmq.namespace
messaging.rocketmq.queue_id rocketmq.queue_id
messaging.rocketmq.queue_offset rocketmq.queue_offset
messaging.rocketmq.send_result rocketmq.send_result
Old system value New system value
aws_sqs aws.sqs

Update telemetry queries, dashboards, attribute filters, and metric views to the new keys and SQS value. Existing capture flags and defaults are unchanged.

The existing messaging schema URL is retained for now. #21075 tracks aligning it with a published schema before 3.0.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-30 07:33 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Copilot AI and others added 2 commits October 29, 2026 17:10
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI changed the title [WIP] Update messaging attribute names for breaking changes Adopt messaging attribute renames for 3.0 Oct 29, 2026
Copilot AI requested a review from trask October 29, 2026 17:20
@trask
trask requested a balanced review from Copilot October 29, 2026 17:24
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Breaking Change Documentation Required

This PR has been labeled as a breaking change. Please ensure you provide the following information:

Migration Notes Required

Please add detailed migration notes to help users understand:

  • What is changing and why
  • How to update their code/configuration
  • Any alternative approaches if applicable
  • Code examples showing before/after usage

Checklist

  • Migration notes added to the PR description
  • Breaking change is documented in the "Unreleased" section of the Changelog, preferably as part of this PR.
  • Consider if this change requires a major version bump

Your migration notes will be included in the release notes to help users upgrade smoothly. The more detailed and helpful they are, the better the user experience will be.


This comment was automatically generated because the breaking change label was applied to this PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The renamed messaging.system.name attribute is still emitted under the 1.43.0 schema, which defines messaging.system, creating a schema mismatch that can break translation by schema-aware consumers.

1 open issue
What changed in this PR

Adopts the messaging attribute renames for 3.0 across shared instrumentation APIs, messaging integrations, and telemetry assertions, without compatibility aliases or new flags.

Changes:

  • Renames messaging.system to messaging.system.name and changes the SQS value to aws.sqs.
  • Moves implemented Kafka, RabbitMQ, and RocketMQ convention attributes into system-specific namespaces.
  • Updates tests, configuration descriptions, documentation, and the breaking-change changelog.
File Description
testing-common/​src/​main/​java/​io/​opentelemetry/​instrumentation/​testing/​junit/​messaging/​KafkaMessagingMetricsAssertions.java Updated as part of this pull request.
smoke-tests-otel-starter/​spring-boot-common/​src/​main/​java/​io/​opentelemetry/​spring/​smoketest/​AbstractKafkaSpringStarterSmokeTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-rabbit-1.1/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​rabbit/​v1_1/​SpringRabbitMqTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-rabbit-1.1/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​rabbit/​v1_1/​SpringRabbitMetricsAssertions.java Updated as part of this pull request.
instrumentation/​spring/​spring-rabbit-1.1/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​rabbit/​v1_1/​SpringRabbitExtraAttributesExtractor.java Updated as part of this pull request.
instrumentation/​spring/​spring-pulsar-1.0/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​spring/​pulsar/​v1_0/​AbstractSpringPulsarTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-kafka-2.7/​testing/​src/​main/​java/​io/​opentelemetry/​testing/​AbstractSpringKafkaTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-kafka-2.7/​testing/​src/​main/​java/​io/​opentelemetry/​testing/​AbstractSpringKafkaNoReceiveTelemetryTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-kafka-2.7/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​spring/​kafka/​v2_7/​SpringKafkaInterceptorTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-kafka-2.7/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​kafka/​v2_7/​SpringKafkaTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-jms/​spring-jms-6.0/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​jms/​v6_0/​SpringListenerSuppressReceiveSpansTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-jms/​spring-jms-6.0/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​jms/​v6_0/​SpringJmsMessageListenerTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-jms/​spring-jms-2.0/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​spring/​jms/​v2_0/​AbstractJmsTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-jms/​spring-jms-2.0/​javaagent/​src/​version20Test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​jms/​v2_0/​SpringJmsBaselineTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-jms/​spring-jms-2.0/​javaagent/​src/​testReceiveSpansDisabled/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​jms/​v2_0/​SpringListenerSuppressReceiveSpansTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-jms/​spring-jms-2.0/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​jms/​v2_0/​SpringListenerTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-jms/​spring-jms-2.0/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​jms/​v2_0/​SpringJmsMessageListenerTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-integration-4.1/​testing/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​integration/​v4_1/​SpringIntegrationTestHelper.java Updated as part of this pull request.
instrumentation/​spring/​spring-integration-4.1/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​integration/​v4_1/​SpringIntegrationAndRabbitTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-integration-4.1/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​integration/​v4_1/​MessageProducerSupportInstrumentationTest.java Updated as part of this pull request.
instrumentation/​spring/​spring-cloud-aws-3.0/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​spring/​cloud/​aws/​v3_0/​AwsSqsTest.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-5.0/​javaagent/​src/​test/​java/​io/​opentelemetry/​instrumentation/​rocketmqclient/​v5_0/​RocketMqSimpleConsumerTest.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-5.0/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rocketmqclient/​v5_0/​RocketMqReceiveSpanLinksExtractor.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-5.0/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rocketmqclient/​v5_0/​RocketMqReceiveBatchMessageAttributeExtractor.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-5.0/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rocketmqclient/​v5_0/​RocketMqProducerAttributeExtractor.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-5.0/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rocketmqclient/​v5_0/​RocketMqConsumerReceiveAttributeExtractor.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-5.0/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rocketmqclient/​v5_0/​RocketMqConsumerProcessAttributeExtractor.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-5.0/​javaagent-unit-tests/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rocketmqclient/​v5_0/​RocketMqReceiveSpanLinksExtractorTest.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-4.8/​metadata.yaml Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-4.8/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​rocketmqclient/​v4_8/​RocketMqProducerWrapperTest.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-4.8/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​rocketmqclient/​v4_8/​RocketMqMetricsTest.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-4.8/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​rocketmqclient/​v4_8/​RocketMqInstrumenterFactoryTest.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-4.8/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​rocketmqclient/​v4_8/​RocketMqBatchProcessSpanLinksExtractorTest.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-4.8/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​rocketmqclient/​v4_8/​RocketMqProducerExperimentalAttributeExtractor.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-4.8/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​rocketmqclient/​v4_8/​RocketMqInstrumenterFactory.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-4.8/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​rocketmqclient/​v4_8/​RocketMqConsumerExperimentalAttributeExtractor.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-4.8/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​rocketmqclient/​v4_8/​RocketMqBatchProcessSpanLinksExtractor.java Updated as part of this pull request.
instrumentation/​rocketmq/​rocketmq-client-4.8/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​rocketmqclient/​v4_8/​RocketMqBatchProcessAttributeExtractor.java Updated as part of this pull request.
instrumentation/​rabbitmq-2.7/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rabbitmq/​v2_7/​RabbitMqTest.java Updated as part of this pull request.
instrumentation/​rabbitmq-2.7/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rabbitmq/​v2_7/​RabbitMqMetricsAssertions.java Updated as part of this pull request.
instrumentation/​rabbitmq-2.7/​javaagent/​src/​recoveryTest/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rabbitmq/​v2_7/​RabbitMqRecoveryTest.java Updated as part of this pull request.
instrumentation/​rabbitmq-2.7/​javaagent/​src/​reactorTest/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rabbitmq/​v2_7/​ReactorRabbitMqTest.java Updated as part of this pull request.
instrumentation/​rabbitmq-2.7/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rabbitmq/​v2_7/​RabbitSingletons.java Updated as part of this pull request.
instrumentation/​rabbitmq-2.7/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rabbitmq/​v2_7/​RabbitReceiveExtraAttributesExtractor.java Updated as part of this pull request.
instrumentation/​rabbitmq-2.7/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rabbitmq/​v2_7/​RabbitDeliveryExtraAttributesExtractor.java Updated as part of this pull request.
instrumentation/​rabbitmq-2.7/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rabbitmq/​v2_7/​RabbitChannelSettleAttributesExtractor.java Updated as part of this pull request.
instrumentation/​rabbitmq-2.7/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​rabbitmq/​v2_7/​RabbitChannelExtraAttributesExtractor.java Updated as part of this pull request.
instrumentation/​pulsar/​pulsar-2.8/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​pulsar/​v2_8/​PulsarClientTest.java Updated as part of this pull request.
instrumentation/​pulsar/​pulsar-2.8/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​pulsar/​v2_8/​PulsarClientSuppressReceiveSpansTest.java Updated as part of this pull request.
instrumentation/​pulsar/​pulsar-2.8/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​pulsar/​v2_8/​AbstractPulsarClientTest.java Updated as part of this pull request.
instrumentation/​nats/​nats-2.17/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​nats/​v2_17/​NatsTestHelper.java Updated as part of this pull request.
instrumentation/​nats/​nats-2.17/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​nats/​v2_17/​AbstractNatsTest.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-streams-0.11/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​kafkastreams/​v0_11/​KafkaStreamsSuppressReceiveSpansTest.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-connect-2.6/​javaagent/​src/​unitTests/​java/​io/​opentelemetry/​javaagent/​instrumentation/​kafkaconnect/​v2_6/​KafkaConnectBatchRecordAttributesTest.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-connect-2.6/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​kafkaconnect/​v2_6/​KafkaConnectConsumedMessagesTest.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-connect-2.6/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​kafkaconnect/​v2_6/​KafkaConnectBatchRecordAttributes.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-clients/​kafka-clients-common-0.11/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​kafkaclients/​common/​v0_11/​internal/​KafkaUtil.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-clients/​kafka-clients-common-0.11/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​kafkaclients/​common/​v0_11/​internal/​KafkaProducerAttributesExtractor.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-clients/​kafka-clients-common-0.11/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​kafkaclients/​common/​v0_11/​internal/​KafkaConsumerAttributesExtractor.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-clients/​kafka-clients-common-0.11/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​kafkaclients/​common/​v0_11/​internal/​KafkaClusterId.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-clients/​kafka-clients-common-0.11/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​kafkaclients/​common/​v0_11/​internal/​KafkaBatchRecordAttributes.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-clients/​kafka-clients-2.6/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​kafkaclients/​v2_6/​WrapperSendExceptionTest.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-clients/​kafka-clients-2.6/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​kafkaclients/​v2_6/​InterceptorsSuppressReceiveSpansTest.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-clients/​kafka-clients-2.6/​library/​README.md Updated as part of this pull request.
instrumentation/​kafka/​kafka-clients/​kafka-clients-0.11/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​kafkaclients/​common/​v0_11/​internal/​AbstractOpenTelemetryMetricsReporterTest.java Updated as part of this pull request.
instrumentation/​kafka/​kafka-clients/​kafka-clients-0.11/​javaagent/​src/​test/​java/​io/​opentelemetry/​instrumentation/​kafkaclients/​common/​v0_11/​internal/​KafkaBatchProcessSpanLinksExtractorTest.java Updated as part of this pull request.
instrumentation/​jms/​jms-3.0/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​jms/​v3_0/​JmsMessageListenerTest.java Updated as part of this pull request.
instrumentation/​jms/​jms-3.0/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​jms/​v3_0/​Jms3SimplifiedApiTest.java Updated as part of this pull request.
instrumentation/​jms/​jms-3.0/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​jms/​v3_0/​AbstractJms3Test.java Updated as part of this pull request.
instrumentation/​jms/​jms-1.1/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​jms/​v1_1/​JmsMessageListenerTest.java Updated as part of this pull request.
instrumentation/​jms/​jms-1.1/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​jms/​v1_1/​AbstractJms1Test.java Updated as part of this pull request.
instrumentation/​camel-2.20/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​camel/​v2_20/​JmsCamelTest.java Updated as part of this pull request.
instrumentation/​camel-2.20/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​camel/​v2_20/​CamelMessagingMetricsAssertions.java Updated as part of this pull request.
instrumentation/​camel-2.20/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​camel/​v2_20/​aws/​SqsCamelTest.java Updated as part of this pull request.
instrumentation/​camel-2.20/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​camel/​v2_20/​aws/​CamelSpanAssertions.java Updated as part of this pull request.
instrumentation/​camel-2.20/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​camel/​v2_20/​aws/​AwsSpanAssertions.java Updated as part of this pull request.
instrumentation/​camel-2.20/​javaagent/​src/​main/​java/​io/​opentelemetry/​javaagent/​instrumentation/​camel/​v2_20/​decorators/​DecoratorRegistry.java Updated as part of this pull request.
instrumentation/​camel-2.20/​javaagent-unit-tests/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​camel/​v2_20/​decorators/​MessagingSystemTest.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-2.2/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v2_2/​SqsMetricsAssertions.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-2.2/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v2_2/​AbstractAws2SqsSuppressReceiveSpansTest.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-2.2/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v2_2/​AbstractAws2SqsBaseTest.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-2.2/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v2_2/​AbstractAws2ClientTest.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-2.2/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v2_2/​internal/​SqsReceiveRequestAttributesGetter.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-2.2/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v2_2/​internal/​SqsProcessRequestAttributesGetter.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-2.2/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v2_2/​internal/​SqsCreateRequestAttributesGetter.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-2.2/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v2_2/​internal/​SqsAttributesGetter.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-1.11/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v1_11/​SqsMetricsAssertions.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-1.11/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v1_11/​AbstractSqsSuppressReceiveSpansTest.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-1.11/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v1_11/​internal/​SqsReceiveRequestAttributesGetter.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-1.11/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v1_11/​internal/​SqsProcessRequestAttributesGetter.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-1.11/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v1_11/​internal/​SqsCreateRequestAttributesGetter.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-1.11/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awssdk/​v1_11/​internal/​SqsAttributesGetter.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-1.11/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​awssdk/​v1_11/​SnsTracingTest.java Updated as part of this pull request.
instrumentation/​aws-sdk/​aws-sdk-1.11/​javaagent/​src/​test/​java/​io/​opentelemetry/​javaagent/​instrumentation/​awssdk/​v1_11/​S3TracingTest.java Updated as part of this pull request.
instrumentation/​aws-lambda/​aws-lambda-events-common-2.2/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awslambdaevents/​common/​v2_2/​internal/​SqsAttributesGetter.java Updated as part of this pull request.
instrumentation/​aws-lambda/​aws-lambda-events-3.11/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​awslambdaevents/​v3_11/​AwsLambdaSqsMessageHandlerTest.java Updated as part of this pull request.
instrumentation/​aws-lambda/​aws-lambda-events-3.11/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​awslambdaevents/​v3_11/​AwsLambdaSqsEventWrapperTest.java Updated as part of this pull request.
instrumentation/​aws-lambda/​aws-lambda-events-2.2/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awslambdaevents/​v2_2/​AwsLambdaSqsMetricsAssertions.java Updated as part of this pull request.
instrumentation/​aws-lambda/​aws-lambda-events-2.2/​testing/​src/​main/​java/​io/​opentelemetry/​instrumentation/​awslambdaevents/​v2_2/​AbstractAwsLambdaSqsEventHandlerTest.java Updated as part of this pull request.
instrumentation-api-incubator/​src/​test/​java/​io/​opentelemetry/​instrumentation/​api/​incubator/​semconv/​messaging/​MessagingProducerMetricsTest.java Updated as part of this pull request.
instrumentation-api-incubator/​src/​test/​java/​io/​opentelemetry/​instrumentation/​api/​incubator/​semconv/​messaging/​MessagingProcessMetricsTest.java Updated as part of this pull request.
instrumentation-api-incubator/​src/​test/​java/​io/​opentelemetry/​instrumentation/​api/​incubator/​semconv/​messaging/​MessagingMetricsAdviceTest.java Updated as part of this pull request.
instrumentation-api-incubator/​src/​test/​java/​io/​opentelemetry/​instrumentation/​api/​incubator/​semconv/​messaging/​MessagingAttributesExtractorTest.java Updated as part of this pull request.
instrumentation-api-incubator/​src/​main/​java/​io/​opentelemetry/​instrumentation/​api/​incubator/​semconv/​messaging/​MessagingMetricsAdvice.java Updated as part of this pull request.
instrumentation-api-incubator/​src/​main/​java/​io/​opentelemetry/​instrumentation/​api/​incubator/​semconv/​messaging/​MessagingAttributesExtractor.java Updated as part of this pull request.
docs/​declarative-configuration-example.yaml Updated as part of this pull request.
docs/​contributing/​style-guide.md Updated as part of this pull request.
CHANGELOG.md Updated as part of this pull request.

Review effort: Balanced

Comment on lines +64 to +65
private static final AttributeKey<String> MESSAGING_SYSTEM_NAME =
AttributeKey.stringKey("messaging.system.name");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the existing schema URL for now, as requested. No published schema includes these renames yet; #21075 tracks aligning it before 3.0 and is assigned to the v3.0.0 milestone. Leaving this finding open because the schema update is deferred, not fixed.

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI requested a review from trask October 29, 2026 18:00
@trask
trask requested a balanced review from Copilot October 29, 2026 18:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the messaging attribute renames.

1 open issue

Review effort: Balanced

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI requested a review from trask October 29, 2026 18:48
Copilot AI requested a review from trask October 29, 2026 19:28
@trask
trask requested a balanced review from Copilot October 29, 2026 19:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The migration guidance omits additional attribute renames and incorrectly claims those keys remain unchanged, risking broken user queries and filters.

2 open issues

Review effort: Balanced

Comment thread CHANGELOG.md Resolved
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@trask
trask marked this pull request as ready for review October 30, 2026 03:35
@trask
trask requested a review from a team as a code owner October 30, 2026 03:35
@opentelemetry-pr-dashboard
opentelemetry-pr-dashboard Bot requested a balanced review from Copilot October 30, 2026 03:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the migration to the 3.0 messaging attribute names.

1 open issue
1 resolved since last review

Review effort: Balanced

@opentelemetry-pr-dashboard
opentelemetry-pr-dashboard Bot requested a balanced review from Copilot October 30, 2026 06:25
Comment thread CHANGELOG.md
the system-specific attribute renames from
[semantic-conventions #4250](https://github.com/open-telemetry/semantic-conventions/pull/4250).
Experimental messaging attributes also lose the `messaging.` prefix (for example,
`messaging.kafka.bootstrap.servers` becomes `kafka.bootstrap.servers`).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kafka.bootstrap.servers might not be the best sample since I think the idea was to get rid of it and instead use it to fill server.address

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The supplied review evidence reports no active issues blocking approval of the messaging telemetry migration.

1 open issue

Review effort: Balanced

@laurit
laurit merged commit b72e337 into main Oct 30, 2026
70 checks passed
@laurit
laurit deleted the copilot/update-messaging-attributes branch October 30, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants