[martincostello]

Fixes #4725

Changes

Use the configuration binding source generator for logging settings when targeting .NET.

Merge requirement checklist

• CONTRIBUTING guidelines followed (license requirements, successful build/tests, etc.)
• Tests added/updated
• CHANGELOG.md file(s) updated for non-trivial changes
• Changes in public API reviewed (if applicable)
• AI usage disclosure:
  • No AI used
  • AI-assisted
  • Bulk AI-generated
• I have the experience and knowledge necessary to understand, review, and validate all content in this PR¹

Footnotes

1. Yes, I can answer maintainer questions about the content of this PR without using AI. ↩

[opentelemetry-pr-dashboard]

Pull request dashboard status

Merged · refreshed 2026-11-10 11:33 UTC

Status above doesn't look right?

• Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

[Copilot]

🟡 Changes recommended

The changelog still contains #TODO and /pull/TODO placeholders that must be replaced with PR number 8100 to provide the required usable pull-request reference.

1 open issue

• Replace TODO placeholders with PR #8100 · New

What changed in this PR

This PR addresses #4725 by moving SDK logging-option binding to the configuration binding source generator on .NET, improving trimming and Native AOT compatibility.

Changes:

• Adds a dedicated options configurator while preserving configuration-change notifications.
• Replaces the reflection-based trimming test with tests for option binding, single registration, and change tokens.
• Documents the change in the SDK changelog.

[!NOTE]
This review was generated with GitHub Copilot.

File	Description
test/​OpenTelemetry.Tests/​Logs/​OpenTelemetryLoggingExtensionsTests.cs	Tests configuration binding, internal defaults, registration, and change notifications.
src/​OpenTelemetry/​Logs/​ILogger/​OpenTelemetryLoggingExtensions.cs	Registers the new configurator and removes obsolete warning suppressions.
src/​OpenTelemetry/​Logs/​ILogger/​OpenTelemetryLoggerOptionsConfigureOptions.cs	Adds the binding call used by the source generator.
src/​OpenTelemetry/​CHANGELOG.md	Records the trimming and Native AOT improvement.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues block the source-generated logging configuration update.

No open issues 🎉

1 resolved since last review

• Replace TODO placeholders with PR #8100

_{Review effort: Balanced}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.06%. Comparing base (1e88560) to head (5147ccc).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8100      +/-   ##
==========================================
- Coverage   93.09%   93.06%   -0.04%     
==========================================
  Files         397      399       +2     
  Lines       23335    23759     +424     
  Branches     4359     4490     +131     
==========================================
+ Hits        21724    22111     +387     
- Misses       1103     1120      +17     
- Partials      508      528      +20     

Flag	Coverage Δ
unittests-Project-Experimental	93.14% <100.00%> (-0.07%)	⬇️
unittests-Project-Stable	93.11% <100.00%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...gger/OpenTelemetryLoggerOptionsConfigureOptions.cs	100.00% <100.00%> (ø)
...try/Logs/ILogger/OpenTelemetryLoggingExtensions.cs	100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

[Kielek]

Changes in general LGTM.

Codex detected one difference:

[P2] Empty boolean settings behave differently on .NET 11. With Logging:OpenTelemetry:IncludeScopes = "", the old binder throws InvalidOperationException; the generated binder skips the value, leaving IncludeScopes at its default. I reproduced this with the new binding call. Preserve the previous validation, or explicitly test and document this change. Comparison output.

[xiang17]

Changes in general LGTM.

Codex detected one difference:

[P2] Empty boolean settings behave differently on .NET 11. With Logging:OpenTelemetry:IncludeScopes = "", the old binder throws InvalidOperationException; the generated binder skips the value, leaving IncludeScopes at its default. I reproduced this with the new binding call. Preserve the previous validation, or explicitly test and document this change. Comparison output.

net11.0 and net472 behave the same way. net10.0 would silently ignore and use default.
Should the SDK defer to .NET Runtime's default behavior or do a consistent check for this case?