Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4760 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 530 530
Lines 21169 21169
=======================================
Hits 18335 18335
Misses 2834 2834 🚀 New features to boost your workflow:
|
…-warnings' into darobs/add-baseline-warnings
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Enable compiler diagnostics for ordinary builds. Currently, OpenTelemetry explicitly configures warning settings only when
OTELCPP_MAINTAINER_MODEis enabled.This change establishes a baseline warning policy for normal builds:
/W3for MSVC and-Wallfor GCC, Clang, and AppleClang. It does not introduce warnings-as-errors or additional warning suppressions.Passing maintainer-mode CI does not ensure that SDK binaries produced by downstream applications or package managers were compiled with meaningful warnings enabled. This affects binary build-policy verification: Microsoft’s open-source BinSkim checks MSVC warning levels, while annocheck in the Red Hat/Fedora ecosystem checks whether warnings such as
-Wallwere enabled.For MSVC, this restores explicit baseline diagnostics following the removal of the CMP0092 compatibility workaround, without reinstating a deprecated CMake policy.
CHANGELOG.mdupdated for non-trivial changes